]> git.alsa-project.org Git - alsa-utils.git/commit
topology: plugins: fix off by 1 mem allocation error
authorYong Zhi <yong.zhi@intel.com>
Sat, 30 Jul 2022 01:05:56 +0000 (20:05 -0500)
committerJaroslav Kysela <perex@perex.cz>
Fri, 4 Nov 2022 21:03:35 +0000 (22:03 +0100)
commit038ed518e9927d915d65de094384025f77e9f0c4
treee8efa1522aa75236e3a347f0d8f9201414126b71
parent7ff994347e83e0505ed012834eb2bda58c557b69
topology: plugins: fix off by 1 mem allocation error

Fix valgrind memcheck error:

==1337389== Invalid write of size 1
==1337389==    at 0x4A4AFAB: __vsnprintf_internal (vsnprintf.c:117)
==1337389==    by 0x4AECF40: __snprintf_chk (snprintf_chk.c:38)
==1337389==    by 0x484B870: snprintf (stdio2.h:67)
==1337389==    by 0x484B870: print_as_hex_bytes (nhlt-processor.c:112)
==1337389==    by 0x484B870: merge_manifest_data (nhlt-processor.c:154)
==1337389==    by 0x484B870: do_nhlt (nhlt-processor.c:420)
==1337389==    by 0x484B870: _snd_topology_nhlt_process (nhlt-processor.c:484)

The consecutive snprintf overwrites always the previous terminator until
it hits the very last call of:

snprintf(dst, ALSA_BYTE_CHARS + 1, "0x%02x,", *nhlt_buffer);

when the size n given to snprintf is 1 more than allocated.

Fixes: https://github.com/alsa-project/alsa-utils/pull/162
Signed-off-by: Yong Zhi <yong.zhi@intel.com>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
topology/nhlt/nhlt-processor.c