]> git.alsa-project.org Git - alsa-utils.git/commit
nhlt: Revert SSP_ANALOG device_type field
authorAndy Ross <andyross@google.com>
Thu, 7 Dec 2023 17:17:57 +0000 (09:17 -0800)
committerJaroslav Kysela <perex@perex.cz>
Fri, 8 Dec 2023 18:46:58 +0000 (19:46 +0100)
commit8f3d84ba19a45411f08bae13ee4dcd8329aa9438
tree6b7fcbfbf293667ec1542a45ab3ef555223bba70
parentb5591747fd432d6289c9594a481982a77d357ed5
nhlt: Revert SSP_ANALOG device_type field

This partially reverts commit 3a47ef2487ed ("topology: nhlt: intel:
support more device types and directions"), which changed the default
device_type in the endpoint descriptor from zero to SSP_ANALOG.

This change breaks the Linux kernel NHLT parser (which AFAICT doesn't
recognize SSP_ANALOG at all), producing errors like:

  [56458.583812] sof-audio-pci-intel-mtl 0000:00:1f.3: no matching blob for sample rate: 48000 sample width: 32 channels: 2
  [56458.583833] sof-audio-pci-intel-mtl 0000:00:1f.3: failed to prepare widget dai-copier.SSP.SSP0-Codec.playback
  [56458.583840] sof-audio-pci-intel-mtl 0000:00:1f.3: Failed to prepare connected widgets
  [56458.583847] sof-audio-pci-intel-mtl 0000:00:1f.3: error: failed widget list set up for pcm 1 dir 0
  [56458.583853] sof-audio-pci-intel-mtl 0000:00:1f.3: ASoC: error at snd_soc_pcm_component_hw_params on 0000:00:1f.3: -22

Revert for compatibility.

Fixes: https://github.com/alsa-project/alsa-utils/pull/248
Signed-off-by: Andy Ross <andyross@google.com>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
topology/nhlt/intel/ssp/ssp-process.c