]> git.alsa-project.org Git - alsa-gobject.git/commit
seq: fix return value when failing devnode detection of ALSA Sequencer character...
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Sat, 12 Jul 2025 08:00:06 +0000 (17:00 +0900)
committer坂本 貴史 <o-takashi@sakamocchi.jp>
Sun, 13 Jul 2025 07:42:16 +0000 (16:42 +0900)
commitfd571ef413ed63b84e02e2e598839222c4a58f28
tree9c3bf7589da16574eecd222a2258847e3c07f4d9
parent1d65665061d6fe4c23ae55b9be312197d02e93c5
seq: fix return value when failing devnode detection of ALSA Sequencer character device

When failing detecting devnode of ALSA Sequencer character device, the
helper function returns negative value to the callers. This is overlooked
in the previous code refactoring. It should return FALSE.

This bug brings the following compiler warnings:

../src/seq/query.c: In function ‘alsaseq_get_system_info’:
../src/seq/query.c:113:9: warning: ‘fd’ may be used uninitialized [-Wmaybe-uninitialized]
  113 |     if (ioctl(fd, SNDRV_SEQ_IOCTL_SYSTEM_INFO, info) < 0) {
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/seq/query.c:101:9: note: ‘fd’ was declared here
  101 |     int fd;
      |

This commit fixes the bug.

Fixes: 31eb1a62345c ("seq: query: rewrite public API to return gboolean according to GNOME convention")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
src/seq/query.c