]> git.alsa-project.org Git - alsa-utils.git/commitdiff
aseqdump: Correct the limit of UMP 7-bit SysEx bytes
authorTakashi Iwai <tiwai@suse.de>
Fri, 26 Jul 2024 12:46:58 +0000 (14:46 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 26 Jul 2024 12:46:58 +0000 (14:46 +0200)
UMP 7-bit SysEx can hold up to 6 bytes, not 14 bytes.

Fixes: 02b0c3af56bd ("aseqdump: Avoid OOB access with broken SysEx UMP packets")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
seq/aseqdump/aseqdump.c

index 85230dffe7c01d77284f3aec6078a3b2d8a50011..090373d928dbc32ecf584e64eb93254d3d547562 100644 (file)
@@ -698,8 +698,8 @@ static void dump_ump_sysex_event(const unsigned int *ump)
        dump_ump_sysex_status("SysEx", snd_ump_sysex_msg_status(ump));
        length = snd_ump_sysex_msg_length(ump);
        printf(" length %d ", length);
-       if (length > 14)
-               length = 14;
+       if (length > 6)
+               length = 6;
        for (i = 0; i < length; i++)
                printf("%s%02x", i ? ":" : "", ump_sysex7_data(ump, i));
        printf("\n");