]> git.alsa-project.org Git - alsa-lib.git/commitdiff
pcm: route: Remove bogus ! in snd_config_get_id() checks
authorTakashi Iwai <tiwai@suse.de>
Tue, 8 Sep 2015 19:48:17 +0000 (21:48 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 8 Sep 2015 19:48:17 +0000 (21:48 +0200)
There are strange "!" added before snd_config_get_id() return value
checks in a couple of places in pcm_route.c.  This essentially makes
the result always positive, making checks bogus.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
src/pcm/pcm_route.c

index 2a437e88b93cf1f308d241d58663f3f14758d4f4..646517d2a9d25e8eb8177e49a36ed7fd9f601687 100644 (file)
@@ -770,7 +770,7 @@ static int determine_chmap(snd_config_t *tt, snd_pcm_chmap_t **tt_chmap)
                snd_config_iterator_t j, jnext;
                snd_config_t *in = snd_config_iterator_entry(i);
 
-               if (!snd_config_get_id(in, &id) < 0)
+               if (snd_config_get_id(in, &id) < 0)
                        continue;
                if (snd_config_get_type(in) != SND_CONFIG_TYPE_COMPOUND)
                        goto err;
@@ -1070,7 +1070,7 @@ static int _snd_pcm_route_determine_ttable(snd_config_t *tt,
                snd_config_iterator_t j, jnext;
                long cchannel;
                const char *id;
-               if (!snd_config_get_id(in, &id) < 0)
+               if (snd_config_get_id(in, &id) < 0)
                        continue;
                err = safe_strtol(id, &cchannel);
                if (err < 0) {