]> git.alsa-project.org Git - alsa-lib.git/commitdiff
src/pcm/pcm_rate.c: add missing free
authorJulia Lawall <julia@diku.dk>
Sun, 18 Sep 2011 20:04:34 +0000 (22:04 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 22 Sep 2011 10:47:44 +0000 (12:47 +0200)
Something that is allocated using calloc is not freed on one
or more error paths.

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Suman Saha <sumsaha@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
src/pcm/pcm_rate.c

index 70e30e5a5dcac9c8d655ef0c69e1e783f0259655..eb35e4ad070f3887138b2fb083e5fe02f312bb7c 100644 (file)
@@ -1392,11 +1392,13 @@ int snd_pcm_rate_open(snd_pcm_t **pcmp, const char *name,
        } else {
                SNDERR("Invalid type for rate converter");
                snd_pcm_close(pcm);
+               free(rate);
                return -EINVAL;
        }
        if (err < 0) {
                SNDERR("Cannot find rate converter");
                snd_pcm_close(pcm);
+               free(rate);
                return -ENOENT;
        }
 #else
@@ -1405,6 +1407,7 @@ int snd_pcm_rate_open(snd_pcm_t **pcmp, const char *name,
        err = open_func(SND_PCM_RATE_PLUGIN_VERSION, &rate->obj, &rate->ops);
        if (err < 0) {
                snd_pcm_close(pcm);
+               free(rate);
                return err;
        }
 #endif
@@ -1413,6 +1416,7 @@ int snd_pcm_rate_open(snd_pcm_t **pcmp, const char *name,
            ! rate->ops.input_frames || ! rate->ops.output_frames) {
                SNDERR("Inproper rate plugin %s initialization", type);
                snd_pcm_close(pcm);
+               free(rate);
                return err;
        }