]> git.alsa-project.org Git - alsa-topology-conf.git/commitdiff
ASoC: topology: Fix bclk and fsync inversion in set_link_hw_format() v1.2.1 v1.2.2
authorKirill Marinushkin <k.marinushkin@gmail.com>
Mon, 16 Apr 2018 18:26:38 +0000 (20:26 +0200)
committerJaroslav Kysela <perex@perex.cz>
Wed, 13 Nov 2019 10:21:11 +0000 (11:21 +0100)
The values of bclk and fsync are inverted WRT the codec. But the existing
solution already works for Broadwell, see the alsa-lib config:

`alsa-lib/src/conf/topology/broadwell/broadwell.conf`

This commit provides the backwards-compatible solution to fix this misuse.
This commit goes in pair with the corresponding patch for linux.

Signed-off-by: Kirill Marinushkin <k.marinushkin@gmail.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Tested-by: Pan Xiuli <xiuli.pan@linux.intel.com>
Tested-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Cc: linux-kernel@vger.kernel.org
Cc: alsa-devel@alsa-project.org
Signed-off-by: Takashi Iwai <tiwai@suse.de>
topology/broadwell/broadwell.conf

index b8405d93eb6c0a61c967e07be042653c8373d9ef..09fc4daaff0dccb181d56b4cfbfff17176c8f2c3 100644 (file)
@@ -393,8 +393,8 @@ SectionGraph."dsp" {
 SectionHWConfig."CodecHWConfig" {
        id "1"
        format "I2S"            # physical audio format.
-       bclk   "master"         # Platform is master of bit clock
-       fsync  "master"         # platform is master of fsync
+       bclk   "codec_slave"    # platform is master of bit clock (codec is slave)
+       fsync  "codec_slave"    # platform is master of fsync (codec is slave)
 }
 
 SectionLink."Codec" {