]> git.alsa-project.org Git - alsa-lib.git/commitdiff
pcm: file: add missing unlock on early return
authorAdam Miartus <amiartus@de.adit-jv.com>
Thu, 23 May 2019 09:44:30 +0000 (11:44 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 23 May 2019 09:55:47 +0000 (11:55 +0200)
Signed-off-by: Adam Miartus <amiartus@de.adit-jv.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
src/pcm/pcm_file.c

index dcaa41d10e35eff00937582b92cedc711df48c26..8e2c70b12ab1afde9e087508dc4538941a71c6fb 100644 (file)
@@ -584,8 +584,10 @@ static snd_pcm_sframes_t snd_pcm_file_readi(snd_pcm_t *pcm, void *buffer, snd_pc
        __snd_pcm_lock(pcm);
 
        frames = _snd_pcm_readi(file->gen.slave, buffer, size);
-       if (frames <= 0)
+       if (frames <= 0) {
+               __snd_pcm_unlock(pcm);
                return frames;
+       }
 
        snd_pcm_areas_from_buf(pcm, areas, buffer);
        snd_pcm_file_areas_read_infile(pcm, areas, 0, frames);
@@ -605,8 +607,10 @@ static snd_pcm_sframes_t snd_pcm_file_readn(snd_pcm_t *pcm, void **bufs, snd_pcm
 
        __snd_pcm_lock(pcm);
        frames = _snd_pcm_readn(file->gen.slave, bufs, size);
-       if (frames <= 0)
+       if (frames <= 0) {
+               __snd_pcm_unlock(pcm);
                return frames;
+       }
 
        snd_pcm_areas_from_bufs(pcm, areas, bufs);
        snd_pcm_file_areas_read_infile(pcm, areas, 0, frames);