]> git.alsa-project.org Git - alsa-lib.git/commitdiff
ucm: add missing uc_mgr_card_close() call to snd_use_case_mgr_open()
authorJaroslav Kysela <perex@perex.cz>
Thu, 15 Apr 2021 14:58:24 +0000 (16:58 +0200)
committerJaroslav Kysela <perex@perex.cz>
Thu, 15 Apr 2021 14:58:29 +0000 (16:58 +0200)
Handle the error path correctly.

Signed-off-by: Jaroslav Kysela <perex@perex.cz>
src/ucm/main.c

index 72255d8095afc2a9cb4fd8e64897a38126e168e5..2b07cc95ef4515363cddfc3e46ce723a5b9185e4 100644 (file)
@@ -1306,8 +1306,10 @@ int snd_use_case_mgr_open(snd_use_case_mgr_t **uc_mgr,
        pthread_mutex_init(&mgr->mutex, NULL);
 
        err = uc_mgr_card_open(mgr);
-       if (err < 0)
-               goto _err;
+       if (err < 0) {
+               uc_mgr_free(mgr);
+               return err;
+       }
 
        err = snd_config_top(&mgr->local_config);
        if (err < 0)
@@ -1337,6 +1339,7 @@ int snd_use_case_mgr_open(snd_use_case_mgr_t **uc_mgr,
        return 0;
 
 _err:
+       uc_mgr_card_close(mgr);
        uc_mgr_free(mgr);
        return err;
 }