]> git.alsa-project.org Git - alsa-lib.git/commitdiff
ucm: Fix uninitialized err in snd_use_case_set()
authorTakashi Iwai <tiwai@suse.de>
Fri, 21 Nov 2014 14:25:30 +0000 (15:25 +0100)
committerTakashi Iwai <tiwai@suse.de>
Fri, 21 Nov 2014 14:32:23 +0000 (15:32 +0100)
The compiler warns like:
  main.c:1664:9: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized]

and actually there are slight code paths that slip.
This patch adds the proper initializations to 0 to return the success
code in these code paths.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
src/ucm/main.c

index 0494728271210ab13dffe4d2f87af0b8a664de5c..37ae4c84aa643f8da97152c7e4bc48ec9b9066ab 100644 (file)
@@ -1443,7 +1443,7 @@ static int set_verb_user(snd_use_case_mgr_t *uc_mgr,
                          const char *verb_name)
 {
         struct use_case_verb *verb;
-        int err;
+        int err = 0;
 
         if (uc_mgr->active_verb &&
             strcmp(uc_mgr->active_verb->name, verb_name) == 0)
@@ -1625,7 +1625,7 @@ int snd_use_case_set(snd_use_case_mgr_t *uc_mgr,
                      const char *value)
 {
        char *str, *str1;
-       int err;
+       int err = 0;
 
        pthread_mutex_lock(&uc_mgr->mutex);
        if (strcmp(identifier, "_verb") == 0)