]> git.alsa-project.org Git - alsa-lib.git/commitdiff
ucm: fix memory leak in the error path (Include)
authorJaroslav Kysela <perex@perex.cz>
Mon, 23 May 2022 11:29:36 +0000 (13:29 +0200)
committerJaroslav Kysela <perex@perex.cz>
Mon, 23 May 2022 11:29:39 +0000 (13:29 +0200)
The included configuration tree must be freed
in the error path, too.

Signed-off-by: Jaroslav Kysela <perex@perex.cz>
src/ucm/ucm_include.c

index 0b55890e248c3423a8602231b2b149cc28f3c527..7def2d312591dfb9a6639d13f9d6a4a093251a36 100644 (file)
@@ -305,13 +305,14 @@ int uc_mgr_evaluate_include(snd_use_case_mgr_t *uc_mgr,
                if (a == NULL)
                        continue;
                err = uc_mgr_evaluate_inplace(uc_mgr, a);
-               if (err < 0)
+               if (err < 0) {
+                       snd_config_delete(a);
                        return err;
+               }
                err = uc_mgr_config_tree_merge(uc_mgr, parent, a, before, after);
+               snd_config_delete(a);
                if (err < 0)
                        return err;
-               snd_config_delete(a);
-               
        }
        return 0;
 }