speaker-test: fix segfault with more than 16 channels

get_channel_name() was accessing the channel_name array without bounds
checking. When using more than 16 channels without a channel map, it
would read past the end of the array and crash.

Closes: https://github.com/alsa-project/alsa-utils/pull/319
Signed-off-by: Geoffrey D. Bennett <g@b4.vu>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>

diff --git a/speaker-test/speaker-test.c b/speaker-test/speaker-test.c
index d3fec2b3adc96214da81c8aa1ba47185b8533ff2..4bf90e3c635c72df228e35bad07fe3e35515f7a0 100644 (file)
--- a/speaker-test/speaker-test.c
+++ b/speaker-test/speaker-test.c
@@ -285,7 +285,9 @@ static const char *get_channel_name(int chn)
     return name ? name : "Unknown";
   }
 #endif
-  return gettext(channel_name[chn]);
+  if (chn < MAX_CHANNELS)
+    return gettext(channel_name[chn]);
+  return "Unknown";
 }
 
 static const int       supported_formats[] = {