]> git.alsa-project.org Git - alsa-lib.git/commitdiff
ucm: exec - fix maxfd used warning
authorJaroslav Kysela <perex@perex.cz>
Tue, 9 Dec 2025 16:48:34 +0000 (17:48 +0100)
committerJaroslav Kysela <perex@perex.cz>
Tue, 9 Dec 2025 16:48:46 +0000 (17:48 +0100)
Fixes: a068cf08 ("ucm: use closefrom instead of close_range")
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
src/ucm/ucm_exec.c

index 713039b4920fffbf2b900d044a880dfb04c260e6..c16a4cfdaec04bbfb675896db51e90f97546772a 100644 (file)
@@ -183,7 +183,7 @@ static int parse_args(char ***argv, int argc, const char *cmd)
  */
 int uc_mgr_exec(const char *prog)
 {
-       pid_t p, f, maxfd;
+       pid_t p, f;
        int err = 0, status;
        char bin[PATH_MAX];
        struct sigaction sa;
@@ -212,8 +212,6 @@ int uc_mgr_exec(const char *prog)
                prog = bin;
        }
 
-       maxfd = sysconf(_SC_OPEN_MAX);
-
        /*
         * block SIGCHLD signal
         * ignore SIGINT and SIGQUIT in parent
@@ -262,8 +260,11 @@ int uc_mgr_exec(const char *prog)
 #if HAVE_DECL_CLOSEFROM
                closefrom(3);
 #else
-               for (f = 3; f < maxfd; f++)
-                       close(f);
+               {
+                       pid_t maxfd = sysconf(_SC_OPEN_MAX);
+                       for (f = 3; f < maxfd; f++)
+                               close(f);
+               }
 #endif
 
                /* install default handlers for the forked process */