]> git.alsa-project.org Git - alsa-lib.git/commitdiff
add missing return value changes for snd_config_get_string() calls
authorJaroslav Kysela <jkysela@redhat.com>
Tue, 11 Nov 2025 15:40:36 +0000 (16:40 +0100)
committerJaroslav Kysela <perex@perex.cz>
Wed, 12 Nov 2025 14:36:29 +0000 (15:36 +0100)
Signed-off-by: Jaroslav Kysela <jkysela@redhat.com>
src/conf.c
src/pcm/pcm_ladspa.c
src/pcm/pcm_rate.c
src/ucm/parser.c

index ce34ff1027c0b189847074440fad602906392892..0f3dc6d6a569c39e0ef154bc39acffb18f9e3c8b 100644 (file)
@@ -5078,7 +5078,9 @@ static int _snd_config_expand(snd_config_t *src,
                {
                        const char *s;
                        snd_config_t *vars = private_data;
-                       snd_config_get_string(src, &s);
+                       err = snd_config_get_string(src, &s);
+                       if (err < 0)
+                               return err;
                        if (s && *s == '$') {
                                err = snd_config_evaluate_string(dst, s, fcn, vars);
                                if (err < 0)
index 17d49409ef7c8ba3bc3cc526b46de224edf58af3..0397219b12608cc8e73e591ba3e06ffa545beff9 100644 (file)
@@ -1753,7 +1753,9 @@ int _snd_pcm_ladspa_open(snd_pcm_t **pcmp, const char *name,
                        continue;
                }
                if (strcmp(id, "path") == 0) {
-                       snd_config_get_string(n, &path);
+                       err = snd_config_get_string(n, &path);
+                       if (err < 0)
+                               return err;
                        continue;
                }
                if (strcmp(id, "channels") == 0) {
index 85bde24137f5faffdf56f9645e0f1113632a6c78..3847a82b0c2e6a2e4350d25d073ab0919772a4ee 100644 (file)
@@ -1561,7 +1561,12 @@ int snd_pcm_rate_open(snd_pcm_t **pcmp, const char *name,
                                continue;
                        if (strcmp(id, "name") != 0)
                                continue;
-                       snd_config_get_string(n, &type);
+                       err = snd_config_get_string(n, &type);
+                       if (err < 0) {
+                               snd_pcm_free(pcm);
+                               free(rate);
+                               return err;
+                       }
                        break;
                }
                if (!type) {
index 7a8c6d390d1c3b329ba7c65f461fd27680b3438b..2ccb11269068c2663e04fffb6da54a24374c4881 100644 (file)
@@ -1089,7 +1089,9 @@ static int parse_sequence(snd_use_case_mgr_t *uc_mgr,
                                snd_error(UCM, "string type is expected for sequence command");
                                return -EINVAL;
                        }
-                       snd_config_get_string(n, &cmd);
+                       err = snd_config_get_string(n, &cmd);
+                       if (err < 0)
+                               return err;
                        continue;
                }