pulse - Fix destruction order on failure

If we failure we should make sure the event loop thread is not running
and hence not accessing our source/sink strings before we free those
strings.

Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/pulse/ctl_pulse.c b/pulse/ctl_pulse.c
index 0b10628f756c175b7fc6ff0c5ff28c44b35d1dc6..8a5546c589a2a1c4669ac8d182076afb3aadd9b4 100644 (file)
--- a/pulse/ctl_pulse.c
+++ b/pulse/ctl_pulse.c
@@ -728,14 +728,11 @@ SND_CTL_PLUGIN_DEFINE_FUNC(pulse)
        return 0;
 
 error:
-       if (ctl->source)
-               free(ctl->source);
-       if (ctl->sink)
-               free(ctl->sink);
-
        if (ctl->p)
                pulse_free(ctl->p);
 
+       free(ctl->source);
+       free(ctl->sink);
        free(ctl);
 
        return err;