]> git.alsa-project.org Git - alsa-lib.git/commitdiff
pcm: add missing "break" in "switch"
authorAntonio Borneo <borneo.antonio@gmail.com>
Sat, 12 May 2012 16:06:23 +0000 (00:06 +0800)
committerTakashi Iwai <tiwai@suse.de>
Mon, 14 May 2012 14:55:39 +0000 (16:55 +0200)
A missing "break" in procedure snd_pcm_write_mmap() causes
execution of "case SND_PCM_ACCESS_MMAP_NONINTERLEAVED" to
fall through next "default" case of the "switch" statement.
Since "default" handles error cases, the procedure returns
error.

The error fixed by this patch blocks transfer of capture
data from kernel to application. Execution get stuck in
alsa-lib, that discards all received data.

Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
src/pcm/pcm_mmap.c

index 6b4405085b06d7884c42316d95062a9493b6b601..83e74e59404982d715978b48549274a1ed713aab 100644 (file)
@@ -622,6 +622,7 @@ snd_pcm_sframes_t snd_pcm_read_mmap(snd_pcm_t *pcm, snd_pcm_uframes_t offset,
                        err = _snd_pcm_readn(pcm->fast_op_arg, bufs, frames);
                        if (err >= 0)
                                frames = err;
+                       break;
                }
                default:
                        SNDMSG("invalid access type %d", pcm->access);