oss: Fix leaks when oss_hw_constraint() fails

If oss_hw_constraint() returns error, we leak 'oss' object and all the
resources referenced by it. This patch fixes the issue by jumping to
'error' label where the proper clean up is already done.

Signed-off-by: Andre Guedes <andre.guedes@intel.com>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

diff --git a/oss/pcm_oss.c b/oss/pcm_oss.c
index dadbb5bc803218c0f0a8d3c9e46608e0f498f6aa..8ab4fb01d37bedcdf7dc899e1e566c0548cd0172 100644 (file)
--- a/oss/pcm_oss.c
+++ b/oss/pcm_oss.c
@@ -413,7 +413,7 @@ SND_PCM_PLUGIN_DEFINE_FUNC(oss)
 
        if ((err = oss_hw_constraint(oss)) < 0) {
                snd_pcm_ioplug_delete(&oss->io);
-               return err;
+               goto error;
        }
 
        *pcmp = oss->io.pcm;