ctl: query: simplify count check

Usually, when creating list of something, count decision at first, then
generate items of the list. At last, the number of items is checked as
the same as the count. However, it's unlikely to have different number
of items.

This commit simplifies the count check.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>

diff --git a/src/ctl/query.c b/src/ctl/query.c
index dcd2cd33bf74c5de010f21695cc809631d89f269..3cf99c901bb94c9304ddd52a04ca1644e7be9b7b 100644 (file)
--- a/src/ctl/query.c
+++ b/src/ctl/query.c
@@ -165,12 +165,9 @@ void alsactl_get_card_id_list(guint **entries, gsize *entry_count,
             udev_device_unref(dev);
         }
     }
-    if (index != count) {
-        g_warn_if_reached();
-        g_free(*entries);
-        *entries = NULL;
-        goto end;
-    }
+
+    g_warn_if_fail(index == count);
+
     *entry_count = count;
 
     qsort(*entries, count, sizeof(guint), compare_guint);