From: Mingjie Shen <shen497@purdue.edu>
Date: Wed, 6 Dec 2023 21:49:26 +0000 (-0500)
Subject: alsactl: fix potential buffer overwrite
X-Git-Tag: v1.2.11~16
X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=004d085c675c56f866f008dbf712ee7503de5b27;p=alsa-utils.git

alsactl: fix potential buffer overwrite

The 'call to sprintf' operation on line 413 requires 21 bytes
but the destination is only 16 bytes.

Fixes: https://github.com/alsa-project/alsa-utils/pull/247
Signed-off-by: Mingjie Shen <shen497@purdue.edu>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
---

diff --git a/alsactl/alsactl.c b/alsactl/alsactl.c
index a854c0b..8ad991a 100644
--- a/alsactl/alsactl.c
+++ b/alsactl/alsactl.c
@@ -242,7 +242,7 @@ int main(int argc, char *argv[])
 	char *cfgfile = SYS_ASOUNDRC;
 	char *initfile = DATADIR "/init/00main";
 	char *pidfile = SYS_PIDFILE;
-	char *cardname, ncardname[16];
+	char *cardname, ncardname[21];
 	char *cmd;
 	char *const *extra_args;
 	const char *const *tmp;