From: Jaroslav Kysela <perex@perex.cz>
Date: Thu, 12 Oct 2006 12:42:45 +0000 (+0200)
Subject: pcm direct plugins - fix memory leak (sconf must be deleted)
X-Git-Tag: v1.0.14rc1~20
X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=10cca7c03b94c435bea2e9369e567a896f25d83a;p=alsa-lib.git

pcm direct plugins - fix memory leak (sconf must be deleted)
---

diff --git a/src/pcm/pcm_dmix.c b/src/pcm/pcm_dmix.c
index 9bd0bd09..4b97909f 100644
--- a/src/pcm/pcm_dmix.c
+++ b/src/pcm/pcm_dmix.c
@@ -1162,8 +1162,7 @@ int _snd_pcm_dmix_open(snd_pcm_t **pcmp, const char *name,
 
 	err = snd_pcm_dmix_open(pcmp, name, &dopen, &params,
 				root, sconf, stream, mode);
-	if (err < 0)
-		snd_config_delete(sconf);
+	snd_config_delete(sconf);
 	return err;
 }
 #ifndef DOC_HIDDEN
diff --git a/src/pcm/pcm_dshare.c b/src/pcm/pcm_dshare.c
index 54f82a33..cb205d30 100644
--- a/src/pcm/pcm_dshare.c
+++ b/src/pcm/pcm_dshare.c
@@ -898,8 +898,7 @@ int _snd_pcm_dshare_open(snd_pcm_t **pcmp, const char *name,
 
 	err = snd_pcm_dshare_open(pcmp, name, &dopen, &params,
 				  root, sconf, stream, mode);
-	if (err < 0)
-		snd_config_delete(sconf);
+	snd_config_delete(sconf);
 	return err;
 }
 #ifndef DOC_HIDDEN
diff --git a/src/pcm/pcm_dsnoop.c b/src/pcm/pcm_dsnoop.c
index 954826f1..8c11562d 100644
--- a/src/pcm/pcm_dsnoop.c
+++ b/src/pcm/pcm_dsnoop.c
@@ -770,8 +770,7 @@ int _snd_pcm_dsnoop_open(snd_pcm_t **pcmp, const char *name,
 
 	err = snd_pcm_dsnoop_open(pcmp, name, &dopen, &params,
 				  root, sconf, stream, mode);
-	if (err < 0)
-		snd_config_delete(sconf);
+	snd_config_delete(sconf);
 	return err;
 }
 #ifndef DOC_HIDDEN