From: Jaroslav Kysela <perex@perex.cz>
Date: Tue, 9 Jun 2020 08:31:50 +0000 (+0200)
Subject: topology: check for the remove() error (coverity)
X-Git-Tag: v1.2.4~24
X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=1dd37fddd865ab9ecdd748d8b704514453ae120b;p=alsa-utils.git

topology: check for the remove() error (coverity)

Signed-off-by: Jaroslav Kysela <perex@perex.cz>
---

diff --git a/topology/topology.c b/topology/topology.c
index 01b2b06..d52b145 100644
--- a/topology/topology.c
+++ b/topology/topology.c
@@ -183,7 +183,9 @@ static int save(const char *output_file, void *buf, size_t size)
 	if (r < 0) {
 		fprintf(stderr, _("Write error: %s\n"), strerror(-errno));
 		if (fd != fileno(stdout)) {
-			remove(fname);
+			if (fname && remove(fname))
+				fprintf(stderr, _("Unable to remove file %s: %s\n"),
+						fname, strerror(-errno));
 			close(fd);
 		}
 		return 1;