From: Takashi Iwai <tiwai@suse.de>
Date: Fri, 6 Jun 2008 15:05:56 +0000 (+0200)
Subject: pcm_mmap_emul: Fix invalid check
X-Git-Tag: v1.0.17rc2~5
X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=2db108cc7201dc0421e3c50d81684ea05d04df30;p=alsa-lib.git

pcm_mmap_emul: Fix invalid check

The check in snd_pcm_mmap_emul_refine() is bogus and buggy.

Since the changed access type is took back at snd_pcm_mmap_emul_refine
again, it has to check the availability of mmap at each time.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/src/pcm/pcm_mmap_emul.c b/src/pcm/pcm_mmap_emul.c
index 896e6326..30949255 100644
--- a/src/pcm/pcm_mmap_emul.c
+++ b/src/pcm/pcm_mmap_emul.c
@@ -62,11 +62,9 @@ static int snd_pcm_mmap_emul_hw_refine(snd_pcm_t *pcm,
 	snd_mask_none(&mask);
 	err = snd_pcm_hw_refine(map->gen.slave, params);
 	if (err < 0) {
-		/* try to use RW_* */
 		snd_pcm_hw_params_t new = *params;
 
-		if (!(params->rmask & (1<<SND_PCM_HW_PARAM_ACCESS)))
-			return err;
+		/* try to use RW_* */
 		if (snd_pcm_access_mask_test(&oldmask,
 					     SND_PCM_ACCESS_MMAP_INTERLEAVED) &&
 		    !snd_pcm_access_mask_test(&oldmask,