From: Pierre Ossman <ossman@cendio.se>
Date: Wed, 7 Mar 2007 14:52:05 +0000 (+0100)
Subject: Improve parameter constraints in alsa-pulse
X-Git-Tag: v1.0.14rc4~7
X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=30247edc84a1eb9479f3c9eb7fa80eab90134b0f;p=alsa-plugins.git

Improve parameter constraints in alsa-pulse

Remove parameter constraints where we actually have none. Also, restrict
total buffer size to 4 MB as current versions of the PulseAudio server
will refuse streams larger than that.

Signed-off-by: Pierre Ossman <ossman@cendio.se>
---

diff --git a/pulse/pcm_pulse.c b/pulse/pcm_pulse.c
index 96affac..96ef6bc 100644
--- a/pulse/pcm_pulse.c
+++ b/pulse/pcm_pulse.c
@@ -643,23 +643,8 @@ static int pulse_hw_constraint(snd_pcm_pulse_t *pcm)
     if (err < 0)
         return err;
 
-    err = snd_pcm_ioplug_set_param_minmax(io, SND_PCM_IOPLUG_HW_RATE,
-        8000, 48000);
-    if (err < 0)
-        return err;
-
-    err = snd_pcm_ioplug_set_param_minmax(io, SND_PCM_IOPLUG_HW_PERIOD_BYTES,
-        1, 4294967295U);
-    if (err < 0)
-        return err;
-
-    err = snd_pcm_ioplug_set_param_minmax(io, SND_PCM_IOPLUG_HW_PERIODS,
-        2, 4294967295U);
-    if (err < 0)
-        return err;
-
     err = snd_pcm_ioplug_set_param_minmax(io, SND_PCM_IOPLUG_HW_BUFFER_BYTES,
-        1, 4294967295U);
+        1, 4 * 1024 * 1024);
     if (err < 0)
         return err;