From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Date: Sat, 14 Nov 2020 08:28:09 +0000 (+0900)
Subject: timer: instance-params: add checks for method arguments
X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=3147675f32e98ad846d2d1439c8db75a7e4c5afa;p=alsa-gobject.git

timer: instance-params: add checks for method arguments

In Rules for use of GError, it's just used for recoverable runtime
error, not for programming error. The invalid arguments are a kind of
programming error.

This commit adds the check for method arguments.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
---

diff --git a/src/timer/instance-params.c b/src/timer/instance-params.c
index 37fa373..b19382c 100644
--- a/src/timer/instance-params.c
+++ b/src/timer/instance-params.c
@@ -165,8 +165,7 @@ void alsatimer_instance_params_set_event_filter(ALSATimerInstanceParams *self,
             (val > SNDRV_TIMER_EVENT_RESUME &&
              val < SNDRV_TIMER_EVENT_MSTART) ||
             val > SNDRV_TIMER_EVENT_MRESUME) {
-            generate_error(error, EINVAL);
-            return;
+            g_return_if_reached();
         }
         filter |= (1u << val);
     }
@@ -225,9 +224,8 @@ void alsatimer_instance_params_get_event_filter(ALSATimerInstanceParams *self,
     }
 
     if (index != count) {
-        generate_error(error, ENXIO);
         g_free(list);
-        return;
+        g_return_if_reached();
     }
 
     *entries = list;