From: Ivan Sorokin <vanyacpp@gmail.com>
Date: Tue, 21 Jan 2014 20:12:50 +0000 (+0400)
Subject: control_hw: fix potential memory leak
X-Git-Tag: v1.0.28~33
X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=336dc58beba0ca7cf5650dc12ed3eb72d61ac6d3;p=alsa-lib.git

control_hw: fix potential memory leak

Signed-off-by: Ivan Sorokin <vanyacpp@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/src/control/control_hw.c b/src/control/control_hw.c
index 148097fa..dfc9dcd5 100644
--- a/src/control/control_hw.c
+++ b/src/control/control_hw.c
@@ -240,8 +240,10 @@ static int snd_ctl_hw_elem_tlv(snd_ctl_t *handle, int op_flag,
 		return -errno;
 	}
 	if (op_flag == 0) {
-		if (xtlv->tlv[1] + 2 * sizeof(unsigned int) > tlv_size)
+		if (xtlv->tlv[1] + 2 * sizeof(unsigned int) > tlv_size) {
+			free(xtlv);
 			return -EFAULT;
+		}
 		memcpy(tlv, xtlv->tlv, xtlv->tlv[1] + 2 * sizeof(unsigned int));
 	}
 	free(xtlv);