From: Jaroslav Kysela <perex@perex.cz>
Date: Tue, 20 Aug 2024 10:56:49 +0000 (+0200)
Subject: topology: pre_process_create_items - remove useless class_id_local
X-Git-Tag: v1.2.13~11
X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=3a8074ceb8ce34e45c2e08a90cb5095890ea078c;p=alsa-utils.git

topology: pre_process_create_items - remove useless class_id_local

This variable was not freed correctly on function return.

Signed-off-by: Jaroslav Kysela <perex@perex.cz>
---

diff --git a/topology/pre-processor.c b/topology/pre-processor.c
index 66b5a58..95e2a89 100644
--- a/topology/pre-processor.c
+++ b/topology/pre-processor.c
@@ -697,13 +697,11 @@ static int pre_process_create_items(struct tplg_pre_processor *tplg_pp,
 	snd_config_iterator_t i, next;
 	snd_config_type_t type;
 	const char *class_id;
-	char *class_id_local;
 	int attr_count = 0;
 	int object_count = *object_count_offset;
 	int ret;
 
 	snd_config_get_id(top, &class_id);
-	class_id_local = strdup(class_id);
 
 	snd_config_for_each(i, next, cfg) {
 		snd_config_iterator_t i2, next2;
@@ -719,7 +717,7 @@ static int pre_process_create_items(struct tplg_pre_processor *tplg_pp,
 		if (snd_config_get_id(n, &attribute) < 0)
 			continue;
 
-		ret = snd_config_make(&local_top, class_id_local, SND_CONFIG_TYPE_COMPOUND);
+		ret = snd_config_make(&local_top, class_id, SND_CONFIG_TYPE_COMPOUND);
 
 		snd_config_for_each(i2, next2, n) {
 			snd_config_t *n2, *new, *new_obj;
@@ -787,7 +785,7 @@ static int pre_process_create_items(struct tplg_pre_processor *tplg_pp,
 			ret = pre_process_add_objects(tplg_pp, &object_count, top,
 						      local_top, new);
 			if (ret < 0) {
-				SNDERR("failed to add objects of type %s\n", class_id_local);
+				SNDERR("failed to add objects of type %s\n", class_id);
 				goto err;
 			}