From: Baek Chang <breakchange@gmail.com>
Date: Tue, 3 May 2011 17:52:34 +0000 (-0700)
Subject: UCM: fix memory leak when executing cset commands
X-Git-Tag: v1.0.25~34
X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=516569bbba7eb0e03f2892a67d8559c4d0bcd17a;p=alsa-lib.git

UCM: fix memory leak when executing cset commands

fix memory leak when executing cset commands.
snd_ctl_elem's are allocated, but never free'ed

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/src/ucm/main.c b/src/ucm/main.c
index 86f29e33..f8ceeebd 100644
--- a/src/ucm/main.c
+++ b/src/ucm/main.c
@@ -173,7 +173,8 @@ static int execute_cset(snd_ctl_t *ctl, char *cset)
 	pos = strrchr(cset, ' ');
 	if (pos == NULL) {
 		uc_error("undefined value for cset >%s<", cset);
-		return -EINVAL;
+		err =  -EINVAL;
+		goto __fail;
 	}
 	*pos = '\0';
 	err = snd_ctl_ascii_elem_id_parse(id, cset);
@@ -196,6 +197,14 @@ static int execute_cset(snd_ctl_t *ctl, char *cset)
 	err = 0;
       __fail:
 	*pos = ' ';
+
+	if (id != NULL)
+		free(id);
+	if (value != NULL)
+		free(value);
+	if (info != NULL)
+		free(info);
+
 	return err;
 }