From: q66 <q66@chimera-linux.org>
Date: Thu, 7 Sep 2023 21:13:01 +0000 (+0200)
Subject: pcm: sofvol plugin: fix signed overflow
X-Git-Tag: v1.2.11~5
X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=55a758a964d430faaa6c9cff112ee6227775df4b;p=alsa-lib.git

pcm: sofvol plugin: fix signed overflow

This fixes functionality on specific setups with UBSan.

Closes: https://github.com/alsa-project/alsa-lib/pull/351
Signed-off-by: q66 <q66@chimera-linux.org>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
---

diff --git a/src/pcm/pcm_softvol.c b/src/pcm/pcm_softvol.c
index 75f2aa0a..38c63679 100644
--- a/src/pcm/pcm_softvol.c
+++ b/src/pcm/pcm_softvol.c
@@ -113,7 +113,7 @@ static inline int MULTI_DIV_32x16(int a, unsigned short b)
 	y.i = 0;
 #if __BYTE_ORDER == __LITTLE_ENDIAN
 	x.i = (unsigned short)v.s[0];
-	x.i *= b;
+	x.i *= (unsigned int)b;
 	y.s[0] = x.s[1];
 	y.i += (int)v.s[1] * b;
 #else