From: David Henningsson Date: Thu, 28 Feb 2013 21:01:08 +0000 (+0100) Subject: hdajackretask: Fix "advanced override" bug X-Git-Tag: v1.0.27~3 X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=6391a860e8caf25210c5b9e6c8f0aa0ff60aa64f;p=alsa-tools.git hdajackretask: Fix "advanced override" bug The values were not correctly retreived from the comboboxes. Signed-off-by: David Henningsson Signed-off-by: Takashi Iwai --- diff --git a/hdajackretask/main-gtk.c b/hdajackretask/main-gtk.c index 65d0f3a..4227669 100644 --- a/hdajackretask/main-gtk.c +++ b/hdajackretask/main-gtk.c @@ -183,14 +183,14 @@ static void update_user_pin_config(ui_data_t* ui) continue; if (ui->free_overrides) { - int i; + int j; int index; unsigned long val = 0; - for (i = 0; i < FREE_OVERRIDES_COUNT; i++) { - index = gtk_combo_box_get_active(GTK_COMBO_BOX(pin_ui->jacktype)); - if (index < 0) + for (j = 0; j < FREE_OVERRIDES_COUNT; j++) { + index = gtk_combo_box_get_active(GTK_COMBO_BOX(pin_ui->free_override_cb[j])); + if (index < 0) break; - val += get_free_override_list(i)[index].value; + val += get_free_override_list(j)[index].value; } if (index < 0) continue;