From: Andre Guedes <andre.guedes@intel.com>
Date: Fri, 28 Sep 2018 21:27:27 +0000 (-0700)
Subject: usb_stream: Fix leaks when us_set_hw_constraint() fails
X-Git-Tag: v1.1.7~2
X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=6b996865126dd559ef186002e45dc6e1594291e7;p=alsa-plugins.git

usb_stream: Fix leaks when us_set_hw_constraint() fails

If us_set_hw_constraint() returns error, we leak the 'us' object and all
the resources referenced by it. This patch fixes the issue by calling
us_free() before returning.

Signed-off-by: Andre Guedes <andre.guedes@intel.com>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/usb_stream/pcm_usb_stream.c b/usb_stream/pcm_usb_stream.c
index 94c83a7..eb4ca98 100644
--- a/usb_stream/pcm_usb_stream.c
+++ b/usb_stream/pcm_usb_stream.c
@@ -455,6 +455,7 @@ static int snd_pcm_us_open(snd_pcm_t **pcmp, const char *name,
 	err = us_set_hw_constraint(us);
 	if (err < 0) {
 		snd_pcm_ioplug_delete(&us->io);
+		us_free(us);
 		return err;
 	}