From: Jaroslav Kysela <perex@perex.cz>
Date: Mon, 8 Jun 2020 16:17:16 +0000 (+0200)
Subject: ucm: fix use-after-free in parse_component_seq()
X-Git-Tag: v1.2.3.1~12
X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=6eb78d41a1688b14b458af4a57e7bcd92120c9fe;p=alsa-lib.git

ucm: fix use-after-free in parse_component_seq()

Signed-off-by: Jaroslav Kysela <perex@perex.cz>
---

diff --git a/src/ucm/parser.c b/src/ucm/parser.c
index b8ee2439..161a85b3 100644
--- a/src/ucm/parser.c
+++ b/src/ucm/parser.c
@@ -617,11 +617,12 @@ static int parse_component_seq(snd_use_case_mgr_t *uc_mgr,
 		return err;
 
 	cmpt_seq->device = find_component_dev(uc_mgr, val);
-	free(val);
 	if (!cmpt_seq->device) {
 		uc_error("error: Cannot find component device %s", val);
+		free(val);
 		return -EINVAL;
 	}
+	free(val);
 
 	/* Parent needs its enable or disable sequence */
 	cmpt_seq->enable = enable;