From: Jaroslav Kysela <perex@perex.cz>
Date: Mon, 23 May 2022 11:29:36 +0000 (+0200)
Subject: ucm: fix memory leak in the error path (Include)
X-Git-Tag: v1.2.7~4
X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=7474518a96bbfad284f68b9267470f4252fa3f78;p=alsa-lib.git

ucm: fix memory leak in the error path (Include)

The included configuration tree must be freed
in the error path, too.

Signed-off-by: Jaroslav Kysela <perex@perex.cz>
---

diff --git a/src/ucm/ucm_include.c b/src/ucm/ucm_include.c
index 0b55890e..7def2d31 100644
--- a/src/ucm/ucm_include.c
+++ b/src/ucm/ucm_include.c
@@ -305,13 +305,14 @@ int uc_mgr_evaluate_include(snd_use_case_mgr_t *uc_mgr,
 		if (a == NULL)
 			continue;
 		err = uc_mgr_evaluate_inplace(uc_mgr, a);
-		if (err < 0)
+		if (err < 0) {
+			snd_config_delete(a);
 			return err;
+		}
 		err = uc_mgr_config_tree_merge(uc_mgr, parent, a, before, after);
+		snd_config_delete(a);
 		if (err < 0)
 			return err;
-		snd_config_delete(a);
-		
 	}
 	return 0;
 }