From: Clemens Ladisch <clemens@ladisch.de>
Date: Mon, 23 Nov 2009 09:56:46 +0000 (+0100)
Subject: mixer: fix enum check
X-Git-Tag: v1.0.22~1
X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=762fe145e9b5c1cff570629ca5ced7cbd252686f;p=alsa-lib.git

mixer: fix enum check

The recent CHECK_ENUM fix uncovered a bug in snd_mixer_selem_is_enumerated()
which would now return -EINVAL for any non-enum control, which would be
interpreted as 'true' by callers like amixer or alsamixer.

Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
---

diff --git a/src/mixer/simple.c b/src/mixer/simple.c
index 606fc3d8..8079fe7a 100644
--- a/src/mixer/simple.c
+++ b/src/mixer/simple.c
@@ -878,7 +878,6 @@ int snd_mixer_selem_set_capture_switch_all(snd_mixer_elem_t *elem, int value)
 int snd_mixer_selem_is_enumerated(snd_mixer_elem_t *elem)
 {
 	CHECK_BASIC(elem);
-	CHECK_ENUM(elem);
 	return sm_selem_ops(elem)->is(elem, SM_PLAY, SM_OPS_IS_ENUMERATED, 0);
 }