From: Takashi Iwai <tiwai@suse.de>
Date: Fri, 9 Dec 2016 16:28:47 +0000 (+0100)
Subject: alsactl: Fix potential NULL dereferences in daemon mode
X-Git-Tag: v1.1.3~1
X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=9839813e7c283ccc0d2a09279df0123d575d82d3;p=alsa-utils.git

alsactl: Fix potential NULL dereferences in daemon mode

The code releasing the each card object may access to NULL when a
bogus count is given.  Add a NULL check just to make sure.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/alsactl/daemon.c b/alsactl/daemon.c
index 127701e..4f0a935 100644
--- a/alsactl/daemon.c
+++ b/alsactl/daemon.c
@@ -451,8 +451,10 @@ save:
 out:
 	free(pfd);
 	remove(pidfile);
-	for (i = 0; i < count; i++)
-		card_free(&cards[i]);
-	free(cards);
+	if (cards) {
+		for (i = 0; i < count; i++)
+			card_free(&cards[i]);
+		free(cards);
+	}
 	return 0;
 }