From: Jaroslav Kysela <jkysela@redhat.com>
Date: Tue, 11 Nov 2025 15:40:36 +0000 (+0100)
Subject: add missing return value changes for snd_config_get_string() calls
X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=a9465869a77b149b7cc1b7e9b37b3463400f6994;p=alsa-lib.git

add missing return value changes for snd_config_get_string() calls

Signed-off-by: Jaroslav Kysela <jkysela@redhat.com>
---

diff --git a/src/conf.c b/src/conf.c
index ce34ff10..0f3dc6d6 100644
--- a/src/conf.c
+++ b/src/conf.c
@@ -5078,7 +5078,9 @@ static int _snd_config_expand(snd_config_t *src,
 		{
 			const char *s;
 			snd_config_t *vars = private_data;
-			snd_config_get_string(src, &s);
+			err = snd_config_get_string(src, &s);
+			if (err < 0)
+				return err;
 			if (s && *s == '$') {
 				err = snd_config_evaluate_string(dst, s, fcn, vars);
 				if (err < 0)
diff --git a/src/pcm/pcm_ladspa.c b/src/pcm/pcm_ladspa.c
index 17d49409..0397219b 100644
--- a/src/pcm/pcm_ladspa.c
+++ b/src/pcm/pcm_ladspa.c
@@ -1753,7 +1753,9 @@ int _snd_pcm_ladspa_open(snd_pcm_t **pcmp, const char *name,
 			continue;
 		}
 		if (strcmp(id, "path") == 0) {
-			snd_config_get_string(n, &path);
+			err = snd_config_get_string(n, &path);
+			if (err < 0)
+				return err;
 			continue;
 		}
 		if (strcmp(id, "channels") == 0) {
diff --git a/src/pcm/pcm_rate.c b/src/pcm/pcm_rate.c
index 85bde241..3847a82b 100644
--- a/src/pcm/pcm_rate.c
+++ b/src/pcm/pcm_rate.c
@@ -1561,7 +1561,12 @@ int snd_pcm_rate_open(snd_pcm_t **pcmp, const char *name,
 				continue;
 			if (strcmp(id, "name") != 0)
 				continue;
-			snd_config_get_string(n, &type);
+			err = snd_config_get_string(n, &type);
+			if (err < 0) {
+				snd_pcm_free(pcm);
+				free(rate);
+				return err;
+			}
 			break;
 		}
 		if (!type) {
diff --git a/src/ucm/parser.c b/src/ucm/parser.c
index 7a8c6d39..2ccb1126 100644
--- a/src/ucm/parser.c
+++ b/src/ucm/parser.c
@@ -1089,7 +1089,9 @@ static int parse_sequence(snd_use_case_mgr_t *uc_mgr,
 				snd_error(UCM, "string type is expected for sequence command");
 				return -EINVAL;
 			}
-			snd_config_get_string(n, &cmd);
+			err = snd_config_get_string(n, &cmd);
+			if (err < 0)
+				return err;
 			continue;
 		}