From: Tanu Kaskinen Date: Fri, 20 Dec 2019 07:26:12 +0000 (+0200) Subject: configure.ac: remove an unnecessary libtool fix X-Git-Tag: v1.2.2~14 X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=b2fe99277a73ec80eac0bd221672dd4aa02defa7;p=alsa-lib.git configure.ac: remove an unnecessary libtool fix This code was added in commit 75d393a563efb578c79364a277087c6326267f52 without explaining why. I assume it was a mistake, since it looks like the libtool problem should have gone away a long time ago. The referenced wiki page https://wiki.debian.org/RpathIssue says: Since libtool 1.5.2 (released 2004-01-25), on Linux libtool no longer sets RPATH for any directories in the dynamic linker search path, so this should no longer be an issue unless upstream used a really old version of libtool when creating their distribution tarball. This code caused problems in OpenEmbedded, where the libtool script is named "x86_64-oe-linux-libtool" or similar rather than just "libtool", so the sed command failed with a file not found error. Rather than adapting the code to OpenEmbedded's peculiarities, it seems best to just remove the unnecessary code altogether. Note: The rpath is set (hardcoded) for 'make' but it is corrected for 'make install' by libtool. Signed-off-by: Tanu Kaskinen Signed-off-by: Jaroslav Kysela --- diff --git a/configure.ac b/configure.ac index 886f87bc..fb60c030 100644 --- a/configure.ac +++ b/configure.ac @@ -765,14 +765,3 @@ test "$build_seq" = "yes" && echo "#include " >> include/asoundlib.h test "$build_seq" = "yes" && echo "#include " >> include/asoundlib.h test "$build_seq" = "yes" && echo "#include " >> include/asoundlib.h cat "$srcdir"/include/asoundlib-tail.h >> include/asoundlib.h - -dnl Taken from https://wiki.debian.org/RpathIssue -case $host in - *-*-linux-gnu) - AC_MSG_RESULT([Fixing libtool for -rpath problems.]) - sed < libtool > libtool-2 \ - 's/^hardcode_libdir_flag_spec.*$'/'hardcode_libdir_flag_spec=" -D__LIBTOOL_IS_A_FOOL__ "/' - mv libtool-2 libtool - chmod 755 libtool - ;; -esac