From: Vinod Koul Date: Thu, 19 Apr 2018 06:11:31 +0000 (+0530) Subject: compress: remove dead code _is_codec_supported() X-Git-Tag: v1.1.7~6 X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=d482a85f83451738a986e8a334fa7297cc7b5410;p=tinycompress.git compress: remove dead code _is_codec_supported() The _is_codec_supported() was dead and none using it, so remove this and eliminate unused function warning compress.c:145:13: warning: ‘_is_codec_supported’ defined but not used [-Wunused-function] We can take from git if user appears Signed-off-by: Vinod Koul --- diff --git a/src/lib/compress.c b/src/lib/compress.c index 8ae6bbd..934690e 100644 --- a/src/lib/compress.c +++ b/src/lib/compress.c @@ -142,49 +142,6 @@ static int get_compress_version(struct compress *compress) return version; } -static bool _is_codec_supported(struct compress *compress, struct compr_config *config, - const struct snd_compr_caps *caps) -{ - bool codec = false; - unsigned int i; - - for (i = 0; i < caps->num_codecs; i++) { - if (caps->codecs[i] == config->codec->id) { - /* found the codec */ - codec = true; - break; - } - } - if (codec == false) { - oops(compress, ENXIO, "this codec is not supported"); - return false; - } - - if (config->fragment_size < caps->min_fragment_size) { - oops(compress, EINVAL, "requested fragment size %d is below min supported %d", - config->fragment_size, caps->min_fragment_size); - return false; - } - if (config->fragment_size > caps->max_fragment_size) { - oops(compress, EINVAL, "requested fragment size %d is above max supported %d", - config->fragment_size, caps->max_fragment_size); - return false; - } - if (config->fragments < caps->min_fragments) { - oops(compress, EINVAL, "requested fragments %d are below min supported %d", - config->fragments, caps->min_fragments); - return false; - } - if (config->fragments > caps->max_fragments) { - oops(compress, EINVAL, "requested fragments %d are above max supported %d", - config->fragments, caps->max_fragments); - return false; - } - - /* TODO: match the codec properties */ - return true; -} - static bool _is_codec_type_supported(int fd, struct snd_codec *codec) { struct snd_compr_caps caps; @@ -271,16 +228,6 @@ struct compress *compress_open(unsigned int card, unsigned int device, config->fragments = caps.max_fragments; } -#if 0 - /* FIXME need to turn this On when DSP supports - * and treat in no support case - */ - if (_is_codec_supported(compress, config, &caps) == false) { - oops(compress, errno, "codec not supported\n"); - goto codec_fail; - } -#endif - memcpy(compress->config, config, sizeof(*compress->config)); fill_compress_params(config, ¶ms);