From: Takashi Iwai <tiwai@suse.de>
Date: Mon, 17 Feb 2025 11:06:09 +0000 (+0100)
Subject: seq: Fix bogus return of snd_seq_client_info_get_ump_conversion()
X-Git-Tag: v1.2.14~26
X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=df8f1cc1ec9d9ee15be5e2c23ad25b9389fd8766;p=alsa-lib.git

seq: Fix bogus return of snd_seq_client_info_get_ump_conversion()

snd_seq_client_info_get_ump_conversion() should have returned the
proper bit of group_filter bit field, but it just did return
midi_version field -- a stupid copy & paste error.  Let's fix it.

Fixes: 2aefb5c41cc0 ("seq: Add UMP support")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/src/seq/seq.c b/src/seq/seq.c
index d3af93f5..38cb1afd 100644
--- a/src/seq/seq.c
+++ b/src/seq/seq.c
@@ -1870,7 +1870,7 @@ int snd_seq_client_info_get_ump_groupless_enabled(const snd_seq_client_info_t *i
 int snd_seq_client_info_get_ump_conversion(const snd_seq_client_info_t *info)
 {
 	assert(info);
-	return info->midi_version;
+	return !(info->group_filter & SNDRV_SEQ_FILTER_NO_CONVERT);
 }
 
 /**