From: Clemens Ladisch <clemens@ladisch.de>
Date: Fri, 10 Jul 2009 05:25:50 +0000 (+0200)
Subject: conf.c: snd_config_set_id: prevent duplicate ids
X-Git-Tag: v1.0.21~21
X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=e2317969e140b2c956db38583dcc0d7f3747670f;p=alsa-lib.git

conf.c: snd_config_set_id: prevent duplicate ids

snd_config_add() checks for duplicate ids, but it was possible to create
duplicates by adding a note and changing the id afterwards with
snd_config_set_id(); so we have to add a check there, too.

Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
---

diff --git a/src/conf.c b/src/conf.c
index ff9d4332..d1fa1097 100644
--- a/src/conf.c
+++ b/src/conf.c
@@ -1521,9 +1521,17 @@ int snd_config_get_id(const snd_config_t *config, const char **id)
  */
 int snd_config_set_id(snd_config_t *config, const char *id)
 {
+	snd_config_iterator_t i, next;
 	char *new_id;
 	assert(config);
 	if (id) {
+		if (config->father) {
+			snd_config_for_each(i, next, config->father) {
+				snd_config_t *n = snd_config_iterator_entry(i);
+				if (n != config && strcmp(id, n->id) == 0)
+					return -EEXIST;
+			}
+		}
 		new_id = strdup(id);
 		if (!new_id)
 			return -ENOMEM;