From: Jaroslav Kysela <perex@perex.cz>
Date: Wed, 7 Dec 2022 13:49:48 +0000 (+0100)
Subject: ucm: execute_sysw - fix possible use-after-free
X-Git-Tag: v1.2.9~29
X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=e29413a2205099b2bffe584210d7a2b59f531f90;p=alsa-lib.git

ucm: execute_sysw - fix possible use-after-free

Signed-off-by: Jaroslav Kysela <perex@perex.cz>
---

diff --git a/src/ucm/main.c b/src/ucm/main.c
index 4f36648c..2ff4d3f3 100644
--- a/src/ucm/main.c
+++ b/src/ucm/main.c
@@ -572,16 +572,17 @@ static int execute_sysw(const char *sysw)
 	wlen = write(fd, value, len);
 	myerrno = errno;
 	close(fd);
-	free(s);
 
 	if (ignore_error)
-		return 0;
+		goto __end;
 
 	if (wlen != (ssize_t)len) {
 		uc_error("unable to write '%s' to '%s': %s", value, path, strerror(myerrno));
 		return -EINVAL;
 	}
 
+__end:
+	free(s);
 	return 0;
 }