From: Takashi Iwai <tiwai@suse.de>
Date: Tue, 8 Sep 2015 20:09:44 +0000 (+0200)
Subject: topology: ctl: Fix access type checks
X-Git-Tag: v1.1.0~24
X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=f41fe763e9bc80783bf1471141ac06d514ffaef3;p=alsa-lib.git

topology: ctl: Fix access type checks

Fix the wrong bit-and check by adding parentheses properly:
  ctl.c: In function ‘tplg_add_bytes’:
  ctl.c:868:22: warning: suggest parentheses around comparison in operand of ‘&’ [-Wparentheses]
     if (be->hdr.access & SNDRV_CTL_ELEM_ACCESS_TLV_READWRITE
                        ^

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/src/topology/ctl.c b/src/topology/ctl.c
index 68c4ce58..7d8787f3 100644
--- a/src/topology/ctl.c
+++ b/src/topology/ctl.c
@@ -865,7 +865,7 @@ int tplg_add_bytes(snd_tplg_t *tplg, struct snd_tplg_bytes_template *bytes_ctl,
 
 	/* check on TLV bytes control */
 	if (be->hdr.access & SNDRV_CTL_ELEM_ACCESS_TLV_CALLBACK) {
-		if (be->hdr.access & SNDRV_CTL_ELEM_ACCESS_TLV_READWRITE
+		if ((be->hdr.access & SNDRV_CTL_ELEM_ACCESS_TLV_READWRITE)
 			!= SNDRV_CTL_ELEM_ACCESS_TLV_READWRITE) {
 			SNDERR("error: Invalid TLV bytes control access 0x%x\n",
 				be->hdr.access);