From: Andre Guedes <andre.guedes@intel.com>
Date: Fri, 28 Sep 2018 21:27:25 +0000 (-0700)
Subject: jack: Fix leaks when jack_set_hw_constraint() fails
X-Git-Tag: v1.1.7~4
X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=f4746667a4a2490f17c2a82b6f421bc3c9bd6de8;p=alsa-plugins.git

jack: Fix leaks when jack_set_hw_constraint() fails

If jack_set_hw_constraint() returns error, we leak the 'jack' object and
all the resources referenced by it. This patch fixes the issue by
calling snd_pcm_jack_free() before returning.

Signed-off-by: Andre Guedes <andre.guedes@intel.com>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/jack/pcm_jack.c b/jack/pcm_jack.c
index b39835e..6aaecac 100644
--- a/jack/pcm_jack.c
+++ b/jack/pcm_jack.c
@@ -538,6 +538,7 @@ static int snd_pcm_jack_open(snd_pcm_t **pcmp, const char *name,
 	err = jack_set_hw_constraint(jack);
 	if (err < 0) {
 		snd_pcm_ioplug_delete(&jack->io);
+		snd_pcm_jack_free(jack);
 		return err;
 	}