From: Takashi Sakamoto Date: Thu, 14 Jul 2016 14:07:21 +0000 (+0900) Subject: pcm: remove alloca() from snd_pcm_get_params X-Git-Tag: v1.1.2~73 X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=f889a8d5decc24c84edccea6a49df014d38a683d;p=alsa-lib.git pcm: remove alloca() from snd_pcm_get_params Both of alloca() and automatic variables keeps storages on stack, while the former generates more instructions than the latter. It's better to use the latter if the size of storage is computable at pre-compile or compile time; i.e. just for structures. This commit obsolete usages of alloca() with automatic variables. Signed-off-by: Takashi Sakamoto Signed-off-by: Takashi Iwai --- diff --git a/src/pcm/pcm.c b/src/pcm/pcm.c index 23655e6d..f8323999 100644 --- a/src/pcm/pcm.c +++ b/src/pcm/pcm.c @@ -8476,17 +8476,16 @@ int snd_pcm_get_params(snd_pcm_t *pcm, snd_pcm_uframes_t *buffer_size, snd_pcm_uframes_t *period_size) { - snd_pcm_hw_params_t *hw; + snd_pcm_hw_params_t params = {0}; int err; assert(pcm); - snd_pcm_hw_params_alloca(&hw); - err = snd_pcm_hw_params_current(pcm, hw); + err = snd_pcm_hw_params_current(pcm, ¶ms); if (err < 0) return err; - err = INTERNAL(snd_pcm_hw_params_get_buffer_size)(hw, buffer_size); + err = INTERNAL(snd_pcm_hw_params_get_buffer_size)(¶ms, buffer_size); if (err < 0) return err; - return INTERNAL(snd_pcm_hw_params_get_period_size)(hw, period_size, + return INTERNAL(snd_pcm_hw_params_get_period_size)(¶ms, period_size, NULL); }