From: Andre Guedes <andre.guedes@intel.com>
Date: Fri, 28 Sep 2018 21:27:24 +0000 (-0700)
Subject: a52: Fix leaks when a52_set_hw_constraint() fails
X-Git-Tag: v1.1.7~5
X-Git-Url: https://git.alsa-project.org/?a=commitdiff_plain;h=fc3f5d51062ff438780e568995792dc809c908cc;p=alsa-plugins.git

a52: Fix leaks when a52_set_hw_constraint() fails

If a52_set_hw_constraint() returns error, we leak 'rec' and
'rec->slave'. This patch fixes the issue by jumping to 'error' label
where the proper clean up is already done.

Signed-off-by: Andre Guedes <andre.guedes@intel.com>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/a52/pcm_a52.c b/a52/pcm_a52.c
index 29ce45f..e431fd0 100644
--- a/a52/pcm_a52.c
+++ b/a52/pcm_a52.c
@@ -978,7 +978,7 @@ SND_PCM_PLUGIN_DEFINE_FUNC(a52)
 
 	if ((err = a52_set_hw_constraint(rec)) < 0) {
 		snd_pcm_ioplug_delete(&rec->io);
-		return err;
+		goto error;
 	}
 
 	*pcmp = rec->io.pcm;