The compress API are expected to return a negative value on an error
with errno indicating the type of error. But in some cases, this is
not happening.
The fix is the oops function always returns -1 and the actual
error number is determined by the global variable errno.
Signed-off-by: Lakshmi N Vinnakota <lakshmi.n.vinnakota@intel.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Fixes the oops() in compress_get_hpointer() to return
-ENODATA instead of errno if the sample rate is zero.
The value in errno here is not related to the reason
we are returning an error.
Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Vinod Koul [Sun, 24 Feb 2013 14:22:21 +0000 (19:52 +0530)]
tinycompress: version 0.1.0
First version release of tinycompress library
dc06a66 tinycompress: version 0.1.0 10fef72 tinycompres: remove unused variable e0810c0 tinycompress: add gapless meta data APIs 8f18a69 cplay: support auto-configuration of fragment size and count 495e5b4 compress: Add makefile for building under standard linux d815993 compress: Add missing header includes bb2650a compress: Block if unable to write all data in single write() acc0960 compress: Allow client to pass "don't care" for fragment size/number e24adce compress: Handle case of pause() during compress_write() 83f0278 compress: Remove hardcoded limit on length of poll() wait f9f3d07 compress: Fix incorrect error message on compress_resume() 14af3b0 compress: Change running from bitfield to plain int eb63cc9 compress: Remove unused buffer_size member from struct compress 21663cc compress: Change compress_write() to take buffer as const void * 0d20d8b compress: Add function to get timestamp in samples 0931870 compress: fix arithmetic exception in compress_get_hpointer 00732dc compress: cache the config values passed 2a455ef compress: remove unused variables 7191a18 compress: make variable 'running' as unsigned dca2963 compress: Do not put newlines on error messages 24a91e3 compress: Return error messages correctly from compress_open 590afad compress: Return error when failing to allocate compress struct 30b28ff compress: Extend limit on error messages bbb37bb compress: add compress_resume cf2e8d4 compress: write when we have a fragment to write 5d5a573 compress: fix the timestamp calculation 55b29e9 initial creation
Vinod Koul [Fri, 22 Feb 2013 09:49:02 +0000 (15:19 +0530)]
tinycompress: add gapless meta data APIs
Based on newly introduced kernel API, we add gapless metatdata to the library.
Since kernel can recieve only key/value pairs for metadata we add a structure for
gapless_metdata and handle this in library
cplay: support auto-configuration of fragment size and count
Default the fragment size and count to zero to take advantage
of the auto-configuration support that was added to tinycompress.
If user doesn't override these by specifying -f and -b values
on the command line, they will be passed to tinycompress as zero
and tinycompress will query the driver for size and count.
compress: Block if unable to write all data in single write()
Previously compress_write() would only block on poll() if the
available space < fragment_size. If the device has a small fragment
size this could lead to it never blocking and instead looping around
doing many small writes. This is bad for power saving.
If we were unable to write all the remaining data in a single write
we want to block until the device reaches a buffer high water mark,
to allow the CPU to sleep.
This change will always attempt to issue the first write providing
avail >= fragment_size. All subsequent loops will block on poll()
before attempting another write() unless there is enough buffer space
to write all remaining data.
compress: Allow client to pass "don't care" for fragment size/number
Client cannot know what is a sensible fragment size and count
for the device unless it has prior knowledge of the precise
hardware. To allow for generic clients not hardcoded for particular
hardware, this change allows fragment_size and fragments to be
passed as 0, meaning "don't care" and tinycompress will choose
default values read from the driver.
compress: Handle case of pause() during compress_write()
If stream is paused() during a compress_write() the poll()
will return 0 or -EBADFD, or the write() will return -EBADFD.
This is not an error so compress_write() should not pass an
error code to the caller. It should abort the write and then
return the number of bytes it had written up to that point.
compress: Remove hardcoded limit on length of poll() wait
For best power-saving we want to sleep on poll() for as long as
possible, we don't want to wake unnecessarily for arbitrary time
limits. Adds function compress_set_max_poll_wait() so that
client can configure the poll() timeout.
compress: Change running from bitfield to plain int
Declaring running as a single-bit bitfield does not save any space
or give any coding advantages, but does leave potential opportunities
for the compiler to be inefficient in how it handles bitfields compared
to how it would handle a machine int.
compress: Add function to get timestamp in samples
The compress_get_hpointer() converts the timestamp into actual
time. But Android needs it in samples. To avoid the inefficiency
of using compress_get_hpointer() and converting into time and then
back into samples, this change adds compress_get_tstamp() which
returns the raw sample count.
Charles Keepax [Fri, 25 Jan 2013 10:43:14 +0000 (10:43 +0000)]
compress: Do not put newlines on error messages
In the oops function text is appended onto the end of the supplied error
message, so newlines appear in the middle of error messages. This patch
removes all newlines from supplied error messages.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Charles Keepax [Fri, 25 Jan 2013 10:43:13 +0000 (10:43 +0000)]
compress: Return error messages correctly from compress_open
The allocated compress object will be freed and bad_compress will be
returned, so error messages written to the allocated compress struct
will be lost. This patch writes error messages to bad_compress for error
paths in compress_open, ensuring that error messages are returned
correctly.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
git://git.alsa-project.org / tinycompress.git / log