]> git.alsa-project.org Git - alsa-gobject.git/log
alsa-gobject.git
4 years agoseq: skip check of return value from g_malloc()
Takashi Sakamoto [Sun, 15 Nov 2020 02:54:07 +0000 (11:54 +0900)]
seq: skip check of return value from g_malloc()

In GLib implementation, the call of g_malloc() can bring program abort
due to memory starvation. This is necessarily preferable because applications
cannot handle the case and GLib has alternative APIs named 'try' to
allow applications to handle the case.

On the other hand, the memory starvation is system wide issue and it's
hard for applications to solve the issue. It's reasonable for the
implementation to have program abort somehow.

Furthermore, the call of g_object_new() can bring program abort due
to memory starvation. It's impossible for applications to handle the
case.

This commit skips check of return value from g_malloc().

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agotimer: obsolete library-wide GQuark for error reporting
Takashi Sakamoto [Sat, 14 Nov 2020 08:28:09 +0000 (17:28 +0900)]
timer: obsolete library-wide GQuark for error reporting

This commit obsoletes library-wide GQuark. This is not exported, thus
it doesn't lose backward compatibility.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agotimer: query: code refactoring to unify open function
Takashi Sakamoto [Sat, 14 Nov 2020 08:28:09 +0000 (17:28 +0900)]
timer: query: code refactoring to unify open function

Some global functions execute the same sequence of operation to open
timer character device.

This commit unifies the sequence into a helper function as code
refactoring.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agotimer: query: use GFileError to report error
Takashi Sakamoto [Sat, 14 Nov 2020 08:28:09 +0000 (17:28 +0900)]
timer: query: use GFileError to report error

In design of ALSA timer, timer character device is not corresponding to
each substance of timer device. It's a kind of interface to query and
operate. Applications adds user instance and operates it to use its
services. Nevertheless, the interface has some functionality without
adding the user instances.

For the functionality, this library has global functions. The functions
are not relevant to the user instance, therefore it's not reasonable to
use error domain specific to the user instance.

This commit uses GFileError to report errors in the global functions.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agotimer: user_instance: update function comment for error reporting
Takashi Sakamoto [Sat, 14 Nov 2020 08:28:09 +0000 (17:28 +0900)]
timer: user_instance: update function comment for error reporting

This commit updates function comment for error reporting with
alsactl_card_error_quark() or g_file_error_quark() domains.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agotimer: user_instance: report error for timer already attached
Takashi Sakamoto [Sat, 14 Nov 2020 08:28:09 +0000 (17:28 +0900)]
timer: user_instance: report error for timer already attached

After opening character device, applications can select event type. The
operation should be done before attaching to any timer device or the other
instances, Else it fails and returns EBUSY error to the applications.

This commit handles it and report local error.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agotimer: user_instance: report error for unattached timer instance
Takashi Sakamoto [Sat, 14 Nov 2020 08:28:09 +0000 (17:28 +0900)]
timer: user_instance: report error for unattached timer instance

When querying or starting the user instance, the instance should be
attached to any timer device or the other instances. Else, applications
receives EBADFD error.

This commit handles it and report local error.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agotimer: user_instance: report error for timer instance not found
Takashi Sakamoto [Sat, 14 Nov 2020 08:28:09 +0000 (17:28 +0900)]
timer: user_instance: report error for timer instance not found

After instantiation and opening character device, application can attach
any timer device to the instance according to the identifier information.
If ALSA timer system has no substance identified by the information,
application receives ENODEV error.

This commit handles it and report local error.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agotimer: user_instance: report error due to open system call
Takashi Sakamoto [Sat, 14 Nov 2020 08:28:09 +0000 (17:28 +0900)]
timer: user_instance: report error due to open system call

The call of open system call can return several types of error from VFS.
It's hard to dispatch all of the error in local error domain.

This commit uses GFileError to dispatch the most of the error. At
failure of conversion to GFileError, local error domain is used.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agotimer: user_instance: report error due to ioctl failure
Takashi Sakamoto [Sat, 14 Nov 2020 08:28:09 +0000 (17:28 +0900)]
timer: user_instance: report error due to ioctl failure

This commit uses class-local error domain to report ioctl failure.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agotimer: user_instance: add GQuark to report error for ALSATimer.UserInstance
Takashi Sakamoto [Sat, 14 Nov 2020 08:28:09 +0000 (17:28 +0900)]
timer: user_instance: add GQuark to report error for ALSATimer.UserInstance

This commit adds new GLib GQuark as a domain of error in instance of
ALSATimerUserInstance class.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agotimer: add GLib enumeration to report type of error for ALSATimer.UserInstance
Takashi Sakamoto [Sat, 14 Nov 2020 08:28:09 +0000 (17:28 +0900)]
timer: add GLib enumeration to report type of error for ALSATimer.UserInstance

This commit adds new GLib enumeration for error reporting in
instance of ALSATimerUserInstance class.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agotimer: user_instance: just return when character device is not opened
Takashi Sakamoto [Sat, 14 Nov 2020 08:28:09 +0000 (17:28 +0900)]
timer: user_instance: just return when character device is not opened

It's programming mistake when operating without opening character device.

This commit uses GLib macro just return in the case with warnings.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agotimer: instance-params: add checks for method arguments
Takashi Sakamoto [Sat, 14 Nov 2020 08:28:09 +0000 (17:28 +0900)]
timer: instance-params: add checks for method arguments

In Rules for use of GError, it's just used for recoverable runtime
error, not for programming error. The invalid arguments are a kind of
programming error.

This commit adds the check for method arguments.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agotimer: add checks for method arguments
Takashi Sakamoto [Sat, 14 Nov 2020 08:28:09 +0000 (17:28 +0900)]
timer: add checks for method arguments

In Rules for use of GError, it's just used for recoverable runtime
error, not for programming error. The invalid arguments are a kind of
programming error.

This commit adds the check for method arguments.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agotimer: check whether method argument for GError is available
Takashi Sakamoto [Sat, 14 Nov 2020 08:28:09 +0000 (17:28 +0900)]
timer: check whether method argument for GError is available

In Rules for use of GError, the check of arguments for GError may be
preferable to avoid to unexpected function call.

This commit adds the check.

Reference: https://developer.gnome.org/glib/stable/glib-Error-Reporting.html
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agotimer: skip check of return value from g_malloc()
Takashi Sakamoto [Sat, 14 Nov 2020 08:28:09 +0000 (17:28 +0900)]
timer: skip check of return value from g_malloc()

In GLib implementation, the call of g_malloc() can bring program abort
due to memory starvation. This is necessarily preferable because applications
cannot handle the case and GLib has alternative APIs named 'try' to
allow applications to handle the case.

On the other hand, the memory starvation is system wide issue and it's
hard for applications to solve the issue. It's reasonable for the
implementation to have program abort somehow.

Furthermore, the call of g_object_new() can bring program abort due
to memory starvation. It's impossible for applications to handle the
case.

This commit skips check of return value from g_malloc().

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agotimer: user_instance: fix function comment
Takashi Sakamoto [Sat, 14 Nov 2020 08:28:09 +0000 (17:28 +0900)]
timer: user_instance: fix function comment

The function comment for documentation includes wrong descriptions.

This commit corrects it.

Fixes: 3a6d788bf47d ("timer: user_instance: add an API to attach user instance to another instance as slave")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agoctl: obsolete library-wide GQuark for error reporting
Takashi Sakamoto [Fri, 13 Nov 2020 07:26:26 +0000 (16:26 +0900)]
ctl: obsolete library-wide GQuark for error reporting

This commit obsoletes library-wide GQuark. This is not exported, thus
it doesn't lose backward compatibility.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agoctl: query: use GFileError to report error
Takashi Sakamoto [Fri, 13 Nov 2020 07:26:26 +0000 (16:26 +0900)]
ctl: query: use GFileError to report error

This commit uses GFileError to report errors in library global functions.

It's better to add new GLib enumerations and GQuark for the reporting,
however it's cumbersome to add them just for the global functions.
Thus this commit just uses the existent error in GLib.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agoctl: card: update function comment for error reporting
Takashi Sakamoto [Fri, 13 Nov 2020 07:26:26 +0000 (16:26 +0900)]
ctl: card: update function comment for error reporting

This commit updates function comment for error reporting with
alsactl_card_error_quark() or g_file_error_quark() domains.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agoctl: card: report error due to existent control element
Takashi Sakamoto [Fri, 13 Nov 2020 07:26:26 +0000 (16:26 +0900)]
ctl: card: report error due to existent control element

The operation to add user-defined control elements returns EBUSY when
sound card has any control element which has the same identifier.

This commit handles the error in local error domain.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agoctl: card: report error due to operations against element owned by the other processes
Takashi Sakamoto [Fri, 13 Nov 2020 07:26:26 +0000 (16:26 +0900)]
ctl: card: report error due to operations against element owned by the other processes

Some operations to control element returns EBUSY or EPERM when the
element is locked for write by the other processes.

This commit handles the error in local error domain.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agoctl: card: report error about unsupported element operation
Takashi Sakamoto [Fri, 13 Nov 2020 07:26:26 +0000 (16:26 +0900)]
ctl: card: report error about unsupported element operation

ANy operation to control element returns EPERM when the operation is not
supported by the element.

This commit handles the error in local error domain.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agoctl: card: report error about element not found
Takashi Sakamoto [Fri, 13 Nov 2020 07:26:26 +0000 (16:26 +0900)]
ctl: card: report error about element not found

Any operation to control element returns ENOENT when sound card doesn't
have the element.

This commit handles the error in local error domain.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agoctl: card: report error about disconnection
Takashi Sakamoto [Fri, 13 Nov 2020 07:26:26 +0000 (16:26 +0900)]
ctl: card: report error about disconnection

When sound card is under disconnection state, operations fail and return
ENODEV error.

This commit handles the situation in local error domain.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agoctl: card: report open error
Takashi Sakamoto [Fri, 13 Nov 2020 07:26:26 +0000 (16:26 +0900)]
ctl: card: report open error

The call of open system call can return several types of error from VFS.
It's hard to dispatch all of the error in local error domain.

This commit uses GFileError to dispatch the most of the error. At
failure of conversion to GFileError, local error domain is used.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agoctl: card: report system call error with own error domain
Takashi Sakamoto [Fri, 13 Nov 2020 07:26:26 +0000 (16:26 +0900)]
ctl: card: report system call error with own error domain

This commit uses class-local error domain to report ioctl failure.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agoctl: card: add GQuark to report error specific for the class
Takashi Sakamoto [Fri, 13 Nov 2020 07:26:26 +0000 (16:26 +0900)]
ctl: card: add GQuark to report error specific for the class

This commit adds new GLib GQuark as a domain of error in instance of
ALSACtlCard class.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agoctl: add GLib enumerations for error reporting
Takashi Sakamoto [Fri, 13 Nov 2020 07:26:26 +0000 (16:26 +0900)]
ctl: add GLib enumerations for error reporting

This commit adds new GLib enumeration for error reporting in
instance of ALSACtlCard class.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agoctl: card: just return when character device is not opened
Takashi Sakamoto [Fri, 13 Nov 2020 07:26:26 +0000 (16:26 +0900)]
ctl: card: just return when character device is not opened

It's programming error when operating without opening character device.

This commit uses GLib macro just return in the case with warnings.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agoctl: add checks for method arguments
Takashi Sakamoto [Fri, 13 Nov 2020 07:26:26 +0000 (16:26 +0900)]
ctl: add checks for method arguments

In Rules for use of GError, it's just used for recoverable runtime
error, not for programming error. The invalid arguments are a kind of
programming error.

This commit adds the check for method arguments.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agoctl: check whether method argument for GError is available
Takashi Sakamoto [Fri, 13 Nov 2020 07:26:26 +0000 (16:26 +0900)]
ctl: check whether method argument for GError is available

In Rules for use of GError, the check of arguments for GError may be
preferable to avoid to unexpected function call.

This commit adds the check.

Reference: https://developer.gnome.org/glib/stable/glib-Error-Reporting.html
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
4 years agoctl: skip check of return value from g_malloc()
Takashi Sakamoto [Fri, 13 Nov 2020 07:26:26 +0000 (16:26 +0900)]
ctl: skip check of return value from g_malloc()

In GLib implementation, the call of g_malloc() can bring program abort
due to memory starvation. This is necessarily preferable because applications
cannot handle the case and GLib has alternative APIs named 'try' to
allow applications to handle the case.

On the other hand, the memory starvation is system wide issue and it's
hard for applications to solve the issue. It's reasonable for the
implementation to have program abort somehow.

Furthermore, the call of g_object_new() can bring program abort due
to memory starvation. It's impossible for applications to handle the
case.

This commit skips check of return value from g_malloc().

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agobump version up to 0.1.0 to release v0.1.0
Takashi Sakamoto [Sun, 21 Jun 2020 10:13:57 +0000 (19:13 +0900)]
bump version up to 0.1.0 to release

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agodoc: seq: reorder sections
Takashi Sakamoto [Sun, 21 Jun 2020 16:53:52 +0000 (01:53 +0900)]
doc: seq: reorder sections

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agodoc: timer: reorder sections
Takashi Sakamoto [Sun, 21 Jun 2020 16:53:32 +0000 (01:53 +0900)]
doc: timer: reorder sections

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoupdate README with alsa-gobject-rs URL
Takashi Sakamoto [Sun, 21 Jun 2020 09:18:39 +0000 (18:18 +0900)]
update README with alsa-gobject-rs URL

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agorawmidi: add an API to retrieve current version of protocol in rawmidi interface
Takashi Sakamoto [Sun, 21 Jun 2020 12:45:52 +0000 (21:45 +0900)]
rawmidi: add an API to retrieve current version of protocol in rawmidi interface

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoseq: add an API to retrieve current version of protocol in sequencer interface
Takashi Sakamoto [Sun, 21 Jun 2020 12:35:14 +0000 (21:35 +0900)]
seq: add an API to retrieve current version of protocol in sequencer interface

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agotimer: add an API to retrieve current version of protocol in timer interface
Takashi Sakamoto [Sun, 21 Jun 2020 12:27:25 +0000 (21:27 +0900)]
timer: add an API to retrieve current version of protocol in timer interface

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoctl: add an API to retrieve current version of protocol in control interface
Takashi Sakamoto [Sun, 21 Jun 2020 12:19:36 +0000 (21:19 +0900)]
ctl: add an API to retrieve current version of protocol in control interface

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agorawmidi: fix indentation
Takashi Sakamoto [Sun, 21 Jun 2020 12:53:38 +0000 (21:53 +0900)]
rawmidi: fix indentation

Fixes: 664d41f58fcd ("rawmidi: generate enumerations")
5 years agorawmidi: stream_pair: fix indentation
Takashi Sakamoto [Sun, 21 Jun 2020 12:48:17 +0000 (21:48 +0900)]
rawmidi: stream_pair: fix indentation

5 years agoseq: fix indentation
Takashi Sakamoto [Sun, 21 Jun 2020 12:57:25 +0000 (21:57 +0900)]
seq: fix indentation

Fixes: fd8fbfb342e5 ("seq: add global method to get information of client for ALSA Sequencer")
5 years agoseq: client_pool: fix indentation
Takashi Sakamoto [Sun, 21 Jun 2020 13:02:17 +0000 (22:02 +0900)]
seq: client_pool: fix indentation

Fixes: 2cb4e8dfccab ("seq: client_pool: add properties")
5 years agoseq: user_client: fix indentation
Takashi Sakamoto [Sun, 21 Jun 2020 13:01:02 +0000 (22:01 +0900)]
seq: user_client: fix indentation

Fixes: 3bbab4321c58 ("seq: user_client: return filled object after creating queue")
5 years agoseq: remove_filter: fix indentation
Takashi Sakamoto [Sun, 21 Jun 2020 12:59:59 +0000 (21:59 +0900)]
seq: remove_filter: fix indentation

Fixes: 50dea0bdde7d ("seq: remove_filter; add constructor methods")
5 years agoseq: event_cntr: fix indentation
Takashi Sakamoto [Sun, 21 Jun 2020 12:58:35 +0000 (21:58 +0900)]
seq: event_cntr: fix indentation

Fixes: 7e43bc934ab5 ("seq: event_cntr: add an API to calculate the amount of cells in pool consumed by a batch of event")
5 years agotimer: instance_params: fix indentation
Takashi Sakamoto [Sun, 21 Jun 2020 12:55:35 +0000 (21:55 +0900)]
timer: instance_params: fix indentation

Fixes: 562145cabf5e ("timer: instance_params: add properties")
5 years agoctl: elem_value: fix indentation
Takashi Sakamoto [Sun, 21 Jun 2020 12:52:09 +0000 (21:52 +0900)]
ctl: elem_value: fix indentation

Fixes: cc98991330fc ("ctl: elem_value: split function with two argument into the one with single argument")
5 years agoseq: supplement to use guint8 for the numerical ID of queue
Takashi Sakamoto [Fri, 19 Jun 2020 11:54:19 +0000 (20:54 +0900)]
seq: supplement to use guint8 for the numerical ID of queue

Fixes: 1550112567c6 ("seq: use guint8 for the numerical ID of queue")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoseq: supplement to use guint8 for the numerical ID of client
Takashi Sakamoto [Fri, 19 Jun 2020 11:53:09 +0000 (20:53 +0900)]
seq: supplement to use guint8 for the numerical ID of client

Fixes: 912236f0a415 ("seq: use guint8 for the numerical ID of client")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoseq: use guint8 for the numerical ID of port
Takashi Sakamoto [Fri, 19 Jun 2020 05:11:28 +0000 (14:11 +0900)]
seq: use guint8 for the numerical ID of port

5 years agoseq: use guint8 for the numerical ID of client
Takashi Sakamoto [Fri, 19 Jun 2020 05:08:27 +0000 (14:08 +0900)]
seq: use guint8 for the numerical ID of client

5 years agoseq: use guint8 for the numerical ID of queue
Takashi Sakamoto [Fri, 19 Jun 2020 04:57:06 +0000 (13:57 +0900)]
seq: use guint8 for the numerical ID of queue

5 years agoseq: queue_timer_data_alsa: use const qualifier to self argument for getter API
Takashi Sakamoto [Wed, 17 Jun 2020 04:23:23 +0000 (13:23 +0900)]
seq: queue_timer_data_alsa: use const qualifier to self argument for getter API

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoseq: event_data_result: use const qualifier to self argument for getter API
Takashi Sakamoto [Wed, 17 Jun 2020 04:22:50 +0000 (13:22 +0900)]
seq: event_data_result: use const qualifier to self argument for getter API

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoseq: event_data_queue: use const qualifier to self argument for getter API
Takashi Sakamoto [Wed, 17 Jun 2020 04:22:29 +0000 (13:22 +0900)]
seq: event_data_queue: use const qualifier to self argument for getter API

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoseq: event_data_note: use const qualifier to self argument for getter API
Takashi Sakamoto [Wed, 17 Jun 2020 04:16:49 +0000 (13:16 +0900)]
seq: event_data_note: use const qualifier to self argument for getter API

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoseq: event_data_ctl: use const qualifier to self argument for getter API
Takashi Sakamoto [Wed, 17 Jun 2020 04:13:15 +0000 (13:13 +0900)]
seq: event_data_ctl: use const qualifier to self argument for getter API

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoseq: event_data_connect: use const qualifier to self argument for getter API
Takashi Sakamoto [Wed, 17 Jun 2020 04:12:37 +0000 (13:12 +0900)]
seq: event_data_connect: use const qualifier to self argument for getter API

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoseq: tstamp: use const qualifier to self argument for getter API
Takashi Sakamoto [Wed, 17 Jun 2020 04:10:48 +0000 (13:10 +0900)]
seq: tstamp: use const qualifier to self argument for getter API

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agotimer: event_data_tstamp: use const qualifier to self argument for getter API
Takashi Sakamoto [Wed, 17 Jun 2020 04:10:03 +0000 (13:10 +0900)]
timer: event_data_tstamp: use const qualifier to self argument for getter API

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agotimer: event_data_tick: use const qualifier to self argument for getter API
Takashi Sakamoto [Wed, 17 Jun 2020 04:09:24 +0000 (13:09 +0900)]
timer: event_data_tick: use const qualifier to self argument for getter API

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agotimer: instance_status: add constructor
Takashi Sakamoto [Mon, 15 Jun 2020 10:31:52 +0000 (19:31 +0900)]
timer: instance_status: add constructor

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agotimer: device_status: add constructor
Takashi Sakamoto [Mon, 15 Jun 2020 10:29:35 +0000 (19:29 +0900)]
timer: device_status: add constructor

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoseq: queue_status: add constructor
Takashi Sakamoto [Mon, 15 Jun 2020 10:27:36 +0000 (19:27 +0900)]
seq: queue_status: add constructor

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agotests: timer: fix test for ALSATimerDeviceStatus
Takashi Sakamoto [Mon, 15 Jun 2020 10:33:25 +0000 (19:33 +0900)]
tests: timer: fix test for ALSATimerDeviceStatus

Fixes: 0146f26c3447 ("timer: device_status: add properties")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agotimer: user_instance: use (inout) annotation to retrieve the status of instance
Takashi Sakamoto [Mon, 15 Jun 2020 02:41:48 +0000 (11:41 +0900)]
timer: user_instance: use (inout) annotation to retrieve the status of instance

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agotimer: use (inout) annotation to retrieve the status of timer device
Takashi Sakamoto [Mon, 15 Jun 2020 02:41:29 +0000 (11:41 +0900)]
timer: use (inout) annotation to retrieve the status of timer device

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoseq: use (inout) annotation to retrieve the status of queue
Takashi Sakamoto [Mon, 15 Jun 2020 02:11:59 +0000 (11:11 +0900)]
seq: use (inout) annotation to retrieve the status of queue

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoupdate README
Takashi Sakamoto [Sun, 14 Jun 2020 12:48:05 +0000 (21:48 +0900)]
update README

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agosamples: add Python 3 sample script for ALSASeq
Takashi Sakamoto [Sun, 14 Jun 2020 12:37:10 +0000 (21:37 +0900)]
samples: add Python 3 sample script for ALSASeq

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agosamples: add Python 3 sample script for ALSATimer
Takashi Sakamoto [Sun, 14 Jun 2020 12:36:54 +0000 (21:36 +0900)]
samples: add Python 3 sample script for ALSATimer

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agosamples: add Python 3 sample script for ALSARawmidi
Takashi Sakamoto [Sun, 14 Jun 2020 12:36:32 +0000 (21:36 +0900)]
samples: add Python 3 sample script for ALSARawmidi

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agosamples: add Python 3 sample script for ALSAHwdep
Takashi Sakamoto [Sun, 14 Jun 2020 12:36:14 +0000 (21:36 +0900)]
samples: add Python 3 sample script for ALSAHwdep

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agosamples: add Python 3 sample script for ALSACtl
Takashi Sakamoto [Sun, 14 Jun 2020 12:35:43 +0000 (21:35 +0900)]
samples: add Python 3 sample script for ALSACtl

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoseq: user_client: return filled object after creating queue
Takashi Sakamoto [Sun, 14 Jun 2020 08:19:42 +0000 (17:19 +0900)]
seq: user_client: return filled object after creating queue

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoseq: user_client: return filled object after creating port
Takashi Sakamoto [Sun, 14 Jun 2020 08:16:09 +0000 (17:16 +0900)]
seq: user_client: return filled object after creating port

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoseq: user_client: add an API to create port with indicated numerical ID
Takashi Sakamoto [Sun, 14 Jun 2020 11:08:19 +0000 (20:08 +0900)]
seq: user_client: add an API to create port with indicated numerical ID

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoseq: port_info: fix description for queue-id property
Takashi Sakamoto [Sun, 14 Jun 2020 08:07:10 +0000 (17:07 +0900)]
seq: port_info: fix description for queue-id property

Fixes: f3457eaf706b ("seq: port_info: add properties")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoseq: user_client: Fix the type of property for int64 value
Takashi Sakamoto [Sun, 14 Jun 2020 08:05:47 +0000 (17:05 +0900)]
seq: user_client: Fix the type of property for int64 value

Fixes: 4e8675f631ce ("seq: client_info: add properties and accessor methods")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agorawmidi: substream_status: use uint64_t for avail and xrun properties
Takashi Sakamoto [Sun, 14 Jun 2020 12:23:36 +0000 (21:23 +0900)]
rawmidi: substream_status: use uint64_t for avail and xrun properties

The avail and xrun members in struct snd_rawmidi_params are defined as
size_t type. The size_t is long type, thus the size is different between
32 bit ABI and 64 bit ABI. This commit uses uint64_t type for the
properties so that the size is the same as these two ABIs.

Fixes: 2371b927816d ("rawmidi: substream_status: add properties")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agotimer: instance_status: unify two arguments to single argument for timestamp
Takashi Sakamoto [Sat, 13 Jun 2020 05:01:36 +0000 (14:01 +0900)]
timer: instance_status: unify two arguments to single argument for timestamp

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agotimer: event_data_tstamp: unify two arguments to single argument for timestamp
Takashi Sakamoto [Sat, 13 Jun 2020 05:01:36 +0000 (14:01 +0900)]
timer: event_data_tstamp: unify two arguments to single argument for timestamp

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agotimer: event: add constructor
Takashi Sakamoto [Sat, 13 Jun 2020 05:01:36 +0000 (14:01 +0900)]
timer: event: add constructor

The constructor is convenient for any test.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoctl: elem_value: split function with two argument into the one with single argument
Takashi Sakamoto [Sat, 13 Jun 2020 05:01:36 +0000 (14:01 +0900)]
ctl: elem_value: split function with two argument into the one with single argument

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoseq: update documentation for system call information
Takashi Sakamoto [Sat, 13 Jun 2020 01:20:47 +0000 (10:20 +0900)]
seq: update documentation for system call information

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agorawmidi: update documentation for system call information
Takashi Sakamoto [Sat, 13 Jun 2020 01:20:47 +0000 (10:20 +0900)]
rawmidi: update documentation for system call information

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agotimer: update documentation for system call information
Takashi Sakamoto [Sat, 13 Jun 2020 01:20:47 +0000 (10:20 +0900)]
timer: update documentation for system call information

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agohwdep: update documentation with system call information
Takashi Sakamoto [Sat, 13 Jun 2020 01:20:47 +0000 (10:20 +0900)]
hwdep: update documentation with system call information

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoctl: update documentation with system call information
Takashi Sakamoto [Sat, 13 Jun 2020 01:20:47 +0000 (10:20 +0900)]
ctl: update documentation with system call information

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoseq: user_client: correct ioctl command to get the usage of queue by client
Takashi Sakamoto [Sat, 13 Jun 2020 01:20:47 +0000 (10:20 +0900)]
seq: user_client: correct ioctl command to get the usage of queue by client

Fixes: 4198dc4f7854 ("seq: user_client: add APIs to register usage of queue")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoseq: user_client: correct ioctl command to update queue
Takashi Sakamoto [Sat, 13 Jun 2020 01:20:47 +0000 (10:20 +0900)]
seq: user_client: correct ioctl command to update queue

Fixes: 2ab3feab20d3 ("seq: user_client: add APIs to create/delete/update queue")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agorawmidi: stream-pair: fix signal name according to internal convention
Takashi Sakamoto [Sat, 13 Jun 2020 01:20:47 +0000 (10:20 +0900)]
rawmidi: stream-pair: fix signal name according to internal convention

Fixes: bd91f8f3d6f2 ("rawmidi: stream_pair: add GObject signal to notify receipt of messages")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agorawmidi: fix leak of file descriptor in global methods of ALSARawmidi
Takashi Sakamoto [Sat, 13 Jun 2020 01:20:47 +0000 (10:20 +0900)]
rawmidi: fix leak of file descriptor in global methods of ALSARawmidi

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agohwdep: fix leak of file descriptor in global methods of ALSAHwdep
Takashi Sakamoto [Sat, 13 Jun 2020 01:20:47 +0000 (10:20 +0900)]
hwdep: fix leak of file descriptor in global methods of ALSAHwdep

Fixes: 53d99ede2486 ("hwdep: add global method to get information of hwdep device")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agotimer: user_instance: add API to choose the type of event to read
Takashi Sakamoto [Fri, 12 Jun 2020 13:24:02 +0000 (22:24 +0900)]
timer: user_instance: add API to choose the type of event to read

Currently ALSATimer.UserInstance has any attach API to decide the type of
event to read. In design of ALSA Timer core, the attach API has two
functionality; to attach or to detach with error for absent timer device.
Current implementation has inconvenient for the functionality due to
execution to choose the type of event in advance. The execution fails
when the instance is already attached.

This commit adds a new API to choose the type of event and split the
call from any attach API.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
5 years agoctl: elem_info: fix SIGSEGV due to missing sentinel for arguments of g_object_new()
Takashi Sakamoto [Fri, 12 Jun 2020 13:24:02 +0000 (22:24 +0900)]
ctl: elem_info: fix SIGSEGV due to missing sentinel for arguments of g_object_new()

Fixes: 5cc31d27e702 ("ctl: elem_info: become concrete class instead of abstract class")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>