From 1dd37fddd865ab9ecdd748d8b704514453ae120b Mon Sep 17 00:00:00 2001 From: Jaroslav Kysela Date: Tue, 9 Jun 2020 10:31:50 +0200 Subject: [PATCH] topology: check for the remove() error (coverity) Signed-off-by: Jaroslav Kysela --- topology/topology.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/topology/topology.c b/topology/topology.c index 01b2b06..d52b145 100644 --- a/topology/topology.c +++ b/topology/topology.c @@ -183,7 +183,9 @@ static int save(const char *output_file, void *buf, size_t size) if (r < 0) { fprintf(stderr, _("Write error: %s\n"), strerror(-errno)); if (fd != fileno(stdout)) { - remove(fname); + if (fname && remove(fname)) + fprintf(stderr, _("Unable to remove file %s: %s\n"), + fname, strerror(-errno)); close(fd); } return 1; -- 2.47.1