From 2316399c77cf23829f7c2470afe0ee2df929f72d Mon Sep 17 00:00:00 2001 From: Jaroslav Kysela Date: Fri, 29 May 2026 12:35:55 +0200 Subject: [PATCH] lib: fix return error inconsistency in populate_compress_plugin_ops Signed-off-by: Jaroslav Kysela --- src/lib/compress.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/lib/compress.c b/src/lib/compress.c index d9ec77a..c1169fa 100644 --- a/src/lib/compress.c +++ b/src/lib/compress.c @@ -113,7 +113,6 @@ struct compress *compress_open(unsigned int card, unsigned int device, static int populate_compress_plugin_ops(struct compress *compress, const char *name) { - unsigned int ret = -1; char *token, *token_saveptr; char *compr_name; char lib_name[128]; @@ -135,22 +134,22 @@ static int populate_compress_plugin_ops(struct compress *compress, const char *n if (!dl_hdl) { fprintf(stderr, "%s: unable to open %s, error: %s\n", __func__, lib_name, dlerror()); - return ret; + return -1; } compress->ops = dlsym(dl_hdl, "compress_plugin_mops"); err = dlerror(); - if (err) { + if (err || compress->ops == NULL) { fprintf(stderr, "%s: dlsym to ops failed, err = '%s'\n", __func__, err); dlclose(dl_hdl); - return ret; + return -1; } if (compress->ops->magic != COMPRESS_OPS_V2) { fprintf(stderr, "%s: dlsym to ops failed, bad magic (%08x)\n", __func__, compress->ops->magic); dlclose(dl_hdl); - return -ENXIO; + return -1; } compress->dl_hdl = dl_hdl; return 0; -- 2.52.0