From 447a676ee5b251607e7d683c7ef1ce762f30f17b Mon Sep 17 00:00:00 2001 From: Jaroslav Kysela Date: Thu, 15 Apr 2021 16:58:24 +0200 Subject: [PATCH] ucm: add missing uc_mgr_card_close() call to snd_use_case_mgr_open() Handle the error path correctly. Signed-off-by: Jaroslav Kysela --- src/ucm/main.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/ucm/main.c b/src/ucm/main.c index 72255d80..2b07cc95 100644 --- a/src/ucm/main.c +++ b/src/ucm/main.c @@ -1306,8 +1306,10 @@ int snd_use_case_mgr_open(snd_use_case_mgr_t **uc_mgr, pthread_mutex_init(&mgr->mutex, NULL); err = uc_mgr_card_open(mgr); - if (err < 0) - goto _err; + if (err < 0) { + uc_mgr_free(mgr); + return err; + } err = snd_config_top(&mgr->local_config); if (err < 0) @@ -1337,6 +1339,7 @@ int snd_use_case_mgr_open(snd_use_case_mgr_t **uc_mgr, return 0; _err: + uc_mgr_card_close(mgr); uc_mgr_free(mgr); return err; } -- 2.47.1