From 4efe03bdfa60fd8c9bd92d0a957cf9637fe52d75 Mon Sep 17 00:00:00 2001 From: Takashi Iwai Date: Wed, 8 Jan 2025 08:29:10 +0100 Subject: [PATCH] aseqdump: Fix typos in messages The message for a MIDI2 pitch bend event was shown incorrectly as channel pressure. Fix it. Also, some MIDI2 note-on events referred to note-off union fields and those should be corrected, too (although both point to the same address, hence there is no difference in the outputs). Closes: https://github.com/alsa-project/alsa-utils/issues/285 Signed-off-by: Takashi Iwai --- seq/aseqdump/aseqdump.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/seq/aseqdump/aseqdump.c b/seq/aseqdump/aseqdump.c index e37c87b..7f14b8f 100644 --- a/seq/aseqdump/aseqdump.c +++ b/seq/aseqdump/aseqdump.c @@ -393,8 +393,8 @@ static void dump_ump_midi1_event(const unsigned int *ump) break; case SND_UMP_MSG_NOTE_ON: printf("Note on %2d, note %d, velocity %s", - channel, m->note_off.note, - midi1_data(m->note_off.velocity)); + channel, m->note_on.note, + midi1_data(m->note_on.velocity)); break; case SND_UMP_MSG_POLY_PRESSURE: printf("Poly pressure %2d, note %d, value %s", @@ -545,9 +545,9 @@ static void dump_ump_midi2_event(const unsigned int *ump) break; case SND_UMP_MSG_NOTE_ON: printf("Note on %2d, note %d, velocity %s, attr type = %d, data = 0x%x", - channel, m->note_off.note, - midi2_velocity(m->note_off.velocity), - m->note_off.attr_type, m->note_off.attr_data); + channel, m->note_on.note, + midi2_velocity(m->note_on.velocity), + m->note_on.attr_type, m->note_on.attr_data); break; case SND_UMP_MSG_POLY_PRESSURE: printf("Poly pressure %2d, note %d, value %s", @@ -572,7 +572,7 @@ static void dump_ump_midi2_event(const unsigned int *ump) midi2_data(m->channel_pressure.data)); break; case SND_UMP_MSG_PITCHBEND: - printf("Channel pressure %2d, value %s", + printf("Pitchbend %2d, value %s", channel, midi2_pitchbend(m->channel_pressure.data)); break; -- 2.47.1